Substitute illegal characters in filename to hyphen #479
Conversation
…-online-tools" This reverts commit 78ec797, reversing changes made to 9b1f727.
…age/spdx-online-tools"" This reverts commit ac22c1d.
…ools into BanulaKumarage-Fixing-#376
|
@goneall @BanulaKumarage Please review. |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -66,7 +66,7 @@ def license_compare_helper(request): | |||
| base_url=urljoin(settings.MEDIA_URL, folder+'/') | |||
| ) | |||
| for myfile in request.FILES.getlist("files"): | |||
| filename = fs.save(myfile.name, myfile) | |||
| filename = fs.save(utils.removeSpecialCharacters(myfile.name), myfile) | |||
There was a problem hiding this comment.
E501: line too long (86 > 79 characters)
❗❗ 3 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| src/app/core.py | 209 |
| src/app/core.py | 319 |
| src/app/core.py | 491 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| @@ -17,6 +17,7 @@ | |||
| import logging | |||
| import re | |||
| import socket | |||
| import unicodedata | |||
There was a problem hiding this comment.
F401: 'unicodedata' imported but unused
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| @@ -17,6 +17,7 @@ | |||
| import logging | |||
| import re | |||
| import socket | |||
| import unicodedata | |||
There was a problem hiding this comment.
vulture-90: unused import 'unicodedata'
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
|
Thanks @rtgdk and @BanulaKumarage I'll merge this in for the next release. |
Fixing #376
Changes on top of #460
Works for other illegal characters as well like
SPDXTagExample-v2.2:#%rohit.spdxAll illegal characters list taken from - https://www.mtu.edu/umc/services/websites/writing/characters-avoid/