Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect on Successful License Submission #449

Closed
BassCoder2808 opened this issue Mar 22, 2023 · 7 comments
Closed

Redirect on Successful License Submission #449

BassCoder2808 opened this issue Mar 22, 2023 · 7 comments
Assignees
Labels
Submit New License Issues related to the submit new license feature

Comments

@BassCoder2808
Copy link
Contributor

BassCoder2808 commented Mar 22, 2023

Whenever we submit a new license, we get redirected to the same page after successful submission, instead, it should take the user to the issues page as discussed with @jlovejoy.

@BassCoder2808 BassCoder2808 changed the title Improving UX Fixing Fallback Mar 24, 2023
@BassCoder2808 BassCoder2808 changed the title Fixing Fallback Redirect on Successful License Submission Mar 24, 2023
@jlovejoy
Copy link
Member

okay, I just tested this b/c I couldn't remember (and sometimes I don't notice these things because I just know where to go!) and yeah, it should not just stay on the submission page. I think going to the newly created GitHub issue would be best.

@jlovejoy
Copy link
Member

as discussed, have newly created Github issue open in new tab/window

@BassCoder2808
Copy link
Contributor Author

Yes, I had made changes to the PR as well #450, @rtgdk we can merge that if nothing else is needed in that

@jlovejoy
Copy link
Member

ok, we'll close issue once PR is merged

@jlovejoy
Copy link
Member

so, this was added, but the new window was blocked by my browser's pop-up blocker... maybe we should consider how common that might be?

@BassCoder2808
Copy link
Contributor Author

Hi @jlovejoy yes for the first time the pop-up window will be blocked for everyone by the browser itself, but once you allow it, it will not ask again. Actually, this is a security feature in every browser by default, so for the first time the user will need to allow pop-ups from tools.spdx.com to open

@goneall
Copy link
Member

goneall commented Jan 19, 2024

@jlovejoy @BassCoder2808 - I'm going to close this as the original issue was resolved with PR #450

If the pop-up blocker is an issue, please open a new issue.

@goneall goneall closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submit New License Issues related to the submit new license feature
Projects
None yet
Development

No branches or pull requests

3 participants