Fixing Redirect on Successful License Submission #450

BassCoder2808 · 2023-03-24T17:44:36Z

Intended to Solve #449

rtgdk · 2023-03-26T13:37:04Z

src/app/templates/app/submit_new_license.html

                if(githubCode == '201'){
                  var successMessage = "The license request has been successfully submitted.";
                  $("#messages").html('<div class="alert alert-success alert-dismissable fade in"><a href="#" class="close" data-dismiss="alert" aria-label="close">&times;</a><strong>Success! </strong>'+ successMessage +'</div>');
+                  window.location.href = "https://github.com/spdx/licnse-list-xml/issues/" + githubIssueId;


I don't think directly transferring users to a new website is ideal. We should either redirect to our own license ID page which should list down the github url (i think it doesn't now) or open this github url in a new tab

Yes @rtgdk , I had also suggested the same idea like once there is a successful license submission the user should get redirected to 'https://tools.spdx.org/app/license_requests/{id}' wherein they can see more about his license instead of just again redirecting them to submit new license. Discussion but @jlovejoy suggested that currently the working is like it gets redirected to the github page which was not working when I tried it.

Yeah opening github link looks fine - both technically and legally. But this should get opened in a new tab. The user should still have a tab to navigate spdx tools.

Ok, I will update the PR according so that whenever the new license get's submitted it gets opened in a new tab

On Track with main

rtgdk · 2023-04-16T03:18:16Z

src/app/views.py

@@ -162,7 +163,7 @@ def submitNewLicense(request):
                        licenseId = licenseRequest.id
                        serverUrl = request.build_absolute_uri('/')
                        licenseRequestUrl = os.path.join(serverUrl, reverse('license-requests')[1:], str(licenseId))
-                        statusCode = utils.createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseComments, licenseSourceUrls, licenseHeader, licenseOsi, licenseExamples, licenseRequestUrl, token, urlType)
+                        statusCode, githubIssueId = utils.createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseComments, licenseSourceUrls, licenseHeader, licenseOsi, licenseExamples, licenseRequestUrl, token, urlType)


I see multiple calls to utils.createIssue. You will need to update it elsewhere as well.

Hi @rtgdk , I have made the above changes, please let me know, if anything else needs to be changed in this

sonatype-lift · 2023-04-16T04:49:09Z

src/app/views.py

@@ -162,7 +163,7 @@ def submitNewLicense(request):
                        licenseId = licenseRequest.id
                        serverUrl = request.build_absolute_uri('/')
                        licenseRequestUrl = os.path.join(serverUrl, reverse('license-requests')[1:], str(licenseId))
-                        statusCode = utils.createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseComments, licenseSourceUrls, licenseHeader, licenseOsi, licenseExamples, licenseRequestUrl, token, urlType)
+                        statusCode, githubIssueId = utils.createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseComments, licenseSourceUrls, licenseHeader, licenseOsi, licenseExamples, licenseRequestUrl, token, urlType)


E501: line too long (235 > 79 characters)

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

src/app/views.py 991

src/app/views.py 1166

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-04-16T05:10:12Z

src/app/views.py

@@ -162,7 +163,9 @@ def submitNewLicense(request):
                        licenseId = licenseRequest.id
                        serverUrl = request.build_absolute_uri('/')
                        licenseRequestUrl = os.path.join(serverUrl, reverse('license-requests')[1:], str(licenseId))
-                        statusCode = utils.createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseComments, licenseSourceUrls, licenseHeader, licenseOsi, licenseExamples, licenseRequestUrl, token, urlType)
+                        statusCode, githubIssueId = utils.createIssue(licenseAuthorName, licenseName, licenseIdentifier, 


W291: trailing whitespace

❗❗ 5 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

src/app/views.py 167

src/app/views.py 993

src/app/views.py 994

src/app/views.py 1170

src/app/views.py 1171

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-04-16T05:10:14Z

src/app/views.py

@@ -162,7 +163,9 @@ def submitNewLicense(request):
                        licenseId = licenseRequest.id
                        serverUrl = request.build_absolute_uri('/')
                        licenseRequestUrl = os.path.join(serverUrl, reverse('license-requests')[1:], str(licenseId))
-                        statusCode = utils.createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseComments, licenseSourceUrls, licenseHeader, licenseOsi, licenseExamples, licenseRequestUrl, token, urlType)
+                        statusCode, githubIssueId = utils.createIssue(licenseAuthorName, licenseName, licenseIdentifier, 
+                                                                      licenseComments, licenseSourceUrls, licenseHeader, 


E501: line too long (120 > 79 characters)

❗❗ 7 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

src/app/views.py 168

src/app/views.py 993

src/app/views.py 994

src/app/views.py 995

src/app/views.py 1170

src/app/views.py 1171

src/app/views.py 1172

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

rtgdk

@BassCoder2808 I see one more use of createIssue in api/views.py. Please make changes, also left a minor comment. Will merge post these.

rtgdk · 2023-06-08T13:35:43Z

src/app/templates/app/submit_new_license.html

+                  setTimeout(function() {
+                    $("#messages").html("");
+                  }, 7000);
+                  window.open("https://github.com/spdx/licnse-list-xml/issues/" + githubIssueId, "_blank");


nit: Let's have this as constant - https://github.com/spdx/licnse-list-xml/issues/

rtgdk · 2023-06-08T13:40:12Z

src/app/utils.py

@@ -352,7 +352,7 @@ def createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseCommen
    headers = {'Authorization': 'token ' + token}
    url = "{0}/issues".format(TYPE_TO_URL_LICENSE[urlType])
    r = requests.post(url, data=json.dumps(payload), headers=headers)
-    return r.status_code
+    return r.status_code, r.json()["number"]


Will r.json() always work without issues? What about when status_code is not as expected like 404, 400, will r.json() parse correctly. Also, will "number" be always in the json? If not let's parse status_code for successfull code list and parse number key if exists. @BassCoder2808

No actually, the number parameter will not be there if there was any issue while creating it through the API, I have added the code to handle that now, let me know if anything else needs to be done in that.

sonatype-lift · 2023-06-08T17:32:41Z

src/api/views.py

@@ -313,7 +313,7 @@ def submit_license(request):
            if 'urlType' in request.POST:
                # This is present only when executing submit license via tests
                urlType = request.POST["urlType"]
-            statusCode = createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseComments, licenseSourceUrls, licenseHeader, licenseOsi, licenseRequestUrl, token, urlType)
+            statusCode, githubIssueId = createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseComments, licenseSourceUrls, licenseHeader, licenseOsi, licenseRequestUrl, token, urlType)


E501: line too long (200 > 79 characters)

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-06-08T17:32:43Z

src/app/utils.py

+            return None, None
+
+
+    if status_code in [200, 201] and "number" in response_json:


E303: too many blank lines (2)

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-06-08T17:32:45Z

src/api/views.py

@@ -313,7 +313,7 @@ def submit_license(request):
            if 'urlType' in request.POST:
                # This is present only when executing submit license via tests
                urlType = request.POST["urlType"]
-            statusCode = createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseComments, licenseSourceUrls, licenseHeader, licenseOsi, licenseRequestUrl, token, urlType)
+            statusCode, githubIssueId = createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseComments, licenseSourceUrls, licenseHeader, licenseOsi, licenseRequestUrl, token, urlType)


E1120: No value for argument 'urlType' in function call

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

@sonatype-lift ignoreall

The ignoreall command is active on this PR, all the existing Lift issues are ignored.

sonatype-lift · 2023-06-08T17:32:47Z

src/api/views.py

@@ -313,7 +313,7 @@ def submit_license(request):
            if 'urlType' in request.POST:
                # This is present only when executing submit license via tests
                urlType = request.POST["urlType"]
-            statusCode = createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseComments, licenseSourceUrls, licenseHeader, licenseOsi, licenseRequestUrl, token, urlType)
+            statusCode, githubIssueId = createIssue(licenseAuthorName, licenseName, licenseIdentifier, licenseComments, licenseSourceUrls, licenseHeader, licenseOsi, licenseRequestUrl, token, urlType)


reportGeneralTypeIssues: Argument missing for parameter "urlType"

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

goneall · 2023-06-24T16:51:50Z

Looks like @rtgdk comment has been resolved - I'll go ahead and merge to include in the next update

whot · 2023-09-08T03:32:04Z

src/app/templates/app/submit_new_license.html

@@ -352,12 +352,15 @@
              data: form,
              success: function (data) {
                var githubCode = data.statusCode;
+                var githubIssueId = data.issueId;
+                var githubUrl = "https://github.com/spdx/licnse-list-xml/issues/";


Note that there is a typo here resulting in a 404 on redirect: licnse

Thanks @whot for pointing out the error, I will crate a PR to solve this

Added the fallback func to github

cb1c711

rtgdk reviewed Mar 26, 2023

View reviewed changes

BassCoder2808 added 2 commits March 26, 2023 23:05

Merge pull request #6 from spdx/main

9e65600

On Track with main

Updated code for opening new window

bab4db8

BassCoder2808 requested a review from rtgdk March 26, 2023 17:50

rtgdk requested changes Apr 16, 2023

View reviewed changes

Changed the utils.createIssue in views

8a771be

BassCoder2808 requested a review from rtgdk April 16, 2023 04:44

sonatype-lift bot reviewed Apr 16, 2023

View reviewed changes

fixed sonatype issues

1092f16

sonatype-lift bot reviewed Apr 16, 2023

View reviewed changes

BassCoder2808 added 2 commits April 16, 2023 10:56

changes in views as per standard

7dd8ef3

final changes as per bot

e541769

rtgdk requested changes Jun 8, 2023

View reviewed changes

rtgdk reviewed Jun 8, 2023

View reviewed changes

rtgdk mentioned this pull request Jun 8, 2023

license request page updates #456

Merged

Mades changes as per the PR

fa33d71

BassCoder2808 requested a review from rtgdk June 8, 2023 17:24

sonatype-lift bot reviewed Jun 8, 2023

View reviewed changes

BassCoder2808 mentioned this pull request Jun 21, 2023

Redirect on Successful License Submission #449

Closed

goneall merged commit ee2cfdf into spdx:main Jun 24, 2023
1 check passed

goneall mentioned this pull request Jun 24, 2023

Remove standard license header field in created issue for new license submission #452

Closed

whot reviewed Sep 8, 2023

View reviewed changes

goneall mentioned this pull request Sep 16, 2023

New license submission redirect has a typo #501

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing Redirect on Successful License Submission #450

Fixing Redirect on Successful License Submission #450

BassCoder2808 commented Mar 24, 2023

rtgdk Mar 26, 2023

BassCoder2808 Mar 26, 2023

rtgdk Mar 26, 2023

BassCoder2808 Mar 26, 2023

rtgdk Apr 16, 2023

BassCoder2808 Apr 16, 2023

sonatype-lift bot Apr 16, 2023

sonatype-lift bot Apr 16, 2023

sonatype-lift bot Apr 16, 2023

rtgdk left a comment

rtgdk Jun 8, 2023

rtgdk Jun 8, 2023

BassCoder2808 Jun 8, 2023

sonatype-lift bot Jun 8, 2023

sonatype-lift bot Jun 8, 2023

sonatype-lift bot Jun 8, 2023

BassCoder2808 Jun 8, 2023

sonatype-lift bot Jun 8, 2023

sonatype-lift bot Jun 8, 2023

goneall commented Jun 24, 2023

whot Sep 8, 2023

BassCoder2808 Sep 8, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

		return None, None


		if status_code in [200, 201] and "number" in response_json:

Fixing Redirect on Successful License Submission #450

Fixing Redirect on Successful License Submission #450

Conversation

BassCoder2808 commented Mar 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Apr 16, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 16, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 16, 2023

Choose a reason for hiding this comment

rtgdk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Jun 8, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jun 8, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jun 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Jun 8, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jun 8, 2023

Choose a reason for hiding this comment

goneall commented Jun 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment