Fixes #51 #54
Merged
Fixes #51 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- packages was a redundant variable in rdfParser2_2 struct. - Intention behind adding packages was to make it similar to rdfParser2_2.files - With this PR, the packages variable has been removed that will partly resolve spdx#51. Signed-off-by: Rishabh Bhatnagar <bhatnagarrishabh4@gmail.com>
Signed-off-by: Rishabh Bhatnagar <bhatnagarrishabh4@gmail.com>
- Files and Packages can now be declared in several parts in different parent tags Signed-off-by: Rishabh Bhatnagar <bhatnagarrishabh4@gmail.com>
|
Thanks @RishabhBhatnagar! I just tried this out on the sample SPDX file from #51, and it definitely appears to fix most of the missing data I mentioned there. However, when translating it from RDF to tag value, I do note that some data is not present in the output. This could be an issue on the tag-value side, but from testing I think it's an issue with the RDF reader. I'll include more detailed comments in the ongoing thread in #51. Thanks again for this! I'll go ahead and merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.