Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A constructor operation isn't linked like the extended attribute is #1519

Closed
foolip opened this issue Sep 7, 2019 · 11 comments
Closed

A constructor operation isn't linked like the extended attribute is #1519

foolip opened this issue Sep 7, 2019 · 11 comments

Comments

@foolip
Copy link
Collaborator

foolip commented Sep 7, 2019

See whatwg/dom#782 (comment).

I haven't looked into what the problem is, but presumably Bikeshed needs some changes.

@Ms2ger is this something you've run into already?

@tabatkins
Copy link
Collaborator

Yes, Bikeshed needs changes here, haven't gotten to it yet. Thanks for the bug to track it.

@foolip
Copy link
Collaborator Author

foolip commented Sep 7, 2019

Thanks for confirming, Tab!

@Ms2ger FYI I think this should block sending lots of PRs for Bikeshed specs, as probably lots of specs would have links broken without the maintainers noticing.

@tabatkins
Copy link
Collaborator

Eh, they'll fix on next build, it'll be fine. I'll fix this either Monday or Tuesday.

@birtles
Copy link
Contributor

birtles commented Sep 9, 2019

Also, it appears the IDs generated for parameters to constructor operations are not correctly scoped to the constructor operation (and hence can overlap with interface members of the same name).

@tabatkins
Copy link
Collaborator

Okay, "constructor" should be linking/dfning properly now. You can autolink to it either as "constructor()" or as "InterfaceName()".

The args problem is due to a bug in widlparser, which plinss is looking into right now.

@tabatkins
Copy link
Collaborator

And arguments should be working now.

@birtles
Copy link
Contributor

birtles commented Sep 19, 2019

I still can't get this to work with the latest bikeshed. The argument linking works but it doesn't link the constructor definition given the following markup:

<pre class="idl">
dictionary DocumentTimelineOptions {
  DOMHighResTimeStamp originTime = 0;
};

[Exposed=Window]
interface DocumentTimeline : AnimationTimeline {
  constructor(optional DocumentTimelineOptions options = {});
};
</pre>

<div class=constructors>

:   <dfn constructor for=DocumentTimeline
    lt="constructor(options)">constructor (options)</dfn>
::  Creates a new {{DocumentTimeline}}.

</div>

I've tried DocumentTimeline(), DocumentTimeline(options), constructor(), and constructor(options) as the link text but none of them appear to work.

@tabatkins
Copy link
Collaborator

Ah! Sorry, that's because constructor() is currently getting marked up as a "method" type.

I'll switch it back to "constructor".

@birtles
Copy link
Contributor

birtles commented Sep 19, 2019

Thank you!

@tabatkins
Copy link
Collaborator

Done in 7b13078

@birtles
Copy link
Contributor

birtles commented Sep 19, 2019

Works a treat. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants