Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[geometry] Update to constructor operations #367

Closed
Ms2ger opened this issue Aug 29, 2019 · 3 comments
Closed

[geometry] Update to constructor operations #367

Ms2ger opened this issue Aug 29, 2019 · 3 comments
Labels
Closed Accepted as Editorial geometry-1 Needs Edits

Comments

@Ms2ger
Copy link

Ms2ger commented Aug 29, 2019

See whatwg/webidl#778.
@Ms2ger Ms2ger changed the title [geometry [geometry] Update to constructor operations Aug 29, 2019
@dirkschulze
Copy link
Contributor

dirkschulze commented Sep 16, 2019 •
edited

@Ms2ger could you please confirm that the change (taking DOMMatrixReadOnly as example) would be correct?

-[Constructor(optional (DOMString or sequence<unrestricted double>) init),
- Exposed=(Window,Worker),
- Serializable]
-interface DOMMatrixReadOnly {
+[Exposed=(Window,Worker),
+ Serializable]
+interface DOMMatrixReadOnly {
+ constructor(optional (DOMString or sequence<unrestricted double>) init);

@Ms2ger
Copy link
Author

Ms2ger commented Sep 16, 2019

Yes, looks good. Thank you!

@dirkschulze
Copy link
Contributor

dirkschulze commented Sep 16, 2019 •
edited

Created a PR for the requested changes here: #373. However, with this change the links in the spec are broken. I'd like to wait for fixes in Bikeshed before landing the PR.

Bikeshed issue for reference: speced/bikeshed#1519

@dirkschulze dirkschulze mentioned this issue Sep 16, 2019
Merged
dirkschulze added a commit that referenced this issue Sep 18, 2019
@dirkschulze
Merge pull request #373 from w3c/use-new-constructor-definition
c18bbf4 
[geometry-1] Use new WebIDL constructor operation. #367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted as Editorial geometry-1 Needs Edits
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ms2ger @dirkschulze