Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make properties/values prettier in regular index #69

Closed
astearns opened this issue Oct 8, 2013 · 3 comments
Closed

Make properties/values prettier in regular index #69

astearns opened this issue Oct 8, 2013 · 3 comments

Comments

@astearns
Copy link

astearns commented Oct 8, 2013

Right now all of the values but none of the properties are being added to the regular index, which isn't that useful. Since bikeshed should know which values belong to which property, the property could be added to the index with each of its values as a sub-item. So instead of this (from flexbox)

<number> (value), 7.3.1
<number> (value), 7.3.2

you'd get

flex-shrink, 7.3.1
   <number> (value), 7.3.1
flex-basis, 7.3.2
   <number> (value), 7.3.2
@tabatkins
Copy link
Collaborator

First half of this work is done now. Multiple index entries with the same text get collapsed into one entry with sub-entries, like:

<number>
  value for flex-shrink, 7.3.1
  value for flex-basis, 7.3.2

Doing it the other way around, where the index entry for 'flex-shrink' includes sub-entries for all of its values, is a bit more difficult, but doable. I'll get to that soonish.

@tabatkins
Copy link
Collaborator

Ugh, this'll actually be much harder than I thought. Problem right now is that the for='' values aren't intrinsically connected to other definitions. They're effectively just a disambiguator, with no verification that they actually mean anything right now.

I need to fix that first before I can take this issue any further.

@tabatkins
Copy link
Collaborator

Done. It's currently limited to properties, but the index entry will now display entries for the values of the property as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants