Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORCID icon not showing up when switching to respect-w3c #3129

Closed
1 task done
andrea-perego opened this issue Sep 22, 2020 · 3 comments · Fixed by #3131
Closed
1 task done

ORCID icon not showing up when switching to respect-w3c #3129

andrea-perego opened this issue Sep 22, 2020 · 3 comments · Fixed by #3131
Labels

Comments

@andrea-perego
Copy link

Important info

Description of problem

What happened?

We recently tried to switch the DCAT specification to respec-w3c, as per https://github.com/w3c/respec/issues/2889

After that, we saw that the ORCID SVG icon is not showing up for some of the editors.

You can check the differences by comparing these two versions:

The editor's data in config.js are all specified consistently, so this should not be the problem:

https://raw.githack.com/w3c/dxwg/andrea-perego-fix-respec-w3c-common-warning/dcat/config.js

The only differences between the editors is that the ones without the ORCID icon have fields url and companyURL set.

Expected behavior (e.g., it shouldn't crash):

ORCID icon showing up for all editors having an ORCID.

Optional, steps to reproduce:

  1. ...
@andrea-perego
Copy link
Author

Thanks for addressing this issue, @sidvishnoi .

However, the ORCID icons are not showing up yet:

https://raw.githack.com/w3c/dxwg/andrea-perego-fix-respec-w3c-common-warning/dcat/index.html

I guess this is because no new built was created (the current one in GH is still v25.16.4).

Do you know when this will happen?

@sidvishnoi
Copy link
Member

Hey, I just released with this fix. Should be fine now :)

@andrea-perego
Copy link
Author

Yep. Confirmed. Thanks a lot, @sidvishnoi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants