Fix deadlock when cancelling prompts #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
Just as a note here, the check failed because the macOS runner failed to start, not because of the change. |
patriksvensson
approved these changes
Jan 31, 2024
|
Merged! Thank you for your contribution. Much appreciated! 👍 |
renovate bot
added a commit
to buehler/dotnet-operator-sdk
that referenced
this pull request
Apr 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Spectre.Console.Testing](https://togithub.com/spectreconsole/spectre.console) | `0.48.0` -> `0.49.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>spectreconsole/spectre.console (Spectre.Console.Testing)</summary> ### [`v0.49.0`](https://togithub.com/spectreconsole/spectre.console/releases/tag/0.49.0) [Compare Source](https://togithub.com/spectreconsole/spectre.console/compare/0.48.0...0.49.0) ##### What's Changed - Cleanup Line-Endings by [@​nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1381 - Added spectre.console.cli to quick-start. by [@​nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1413 - Fix rendering of ListPrompt for odd pageSizes by [@​nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1365 - Remove mandelbrot example due to conflicting license by [@​patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1426 - Allow specifying a property to ignore the use of build-time packages for versioning and analysis by [@​baronfel](https://togithub.com/baronfel) in [spectreconsole/spectre.console#1425 - Add the possibility to register multiple interceptors by [@​nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1412 - Added the ITypeResolver to the ExceptionHandler by [@​nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1411 - Updated typo in commandApp.md by [@​DarqueWarrior](https://togithub.com/DarqueWarrior) in [spectreconsole/spectre.console#1431 - Command with -v displays app version instead of executing the command by [@​FrankRay78](https://togithub.com/FrankRay78) in [spectreconsole/spectre.console#1427 - HelpProvider colors should be configurable by [@​FrankRay78](https://togithub.com/FrankRay78) in [spectreconsole/spectre.console#1408 - Direct contributors to the current CONTRIBUTING.md by [@​tonycknight](https://togithub.com/tonycknight) in [spectreconsole/spectre.console#1435 - Fix deadlock when cancelling prompts by [@​caesay](https://togithub.com/caesay) in [spectreconsole/spectre.console#1439 - Add progress bar value formatter by [@​jsheely](https://togithub.com/jsheely) in [spectreconsole/spectre.console#1414 - Update dependencies and do some clean-up by [@​patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1440 - Delete \[UsesVerify], which has become obsolete through the latest update. by [@​danielcweber](https://togithub.com/danielcweber) in [spectreconsole/spectre.console#1456 - Don't erase secret prompt text upon backspace when mask is null by [@​danielcweber](https://togithub.com/danielcweber) in [spectreconsole/spectre.console#1458 - Update dependencies to the latest version by [@​patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1459 - Automatically register command settings by [@​patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1463 - chore: Update dependency dotnet-example to v3.1.0 by [@​renovate](https://togithub.com/renovate) in [spectreconsole/spectre.console#1470 - chore: Update dependency Roslynator.Analyzers to v4.11.0 by [@​renovate](https://togithub.com/renovate) in [spectreconsole/spectre.console#1473 - Remove \[DebuggerDisplay] from Paragraph by [@​martincostello](https://togithub.com/martincostello) in [spectreconsole/spectre.console#1477 - Selection Prompt Search by [@​slang25](https://togithub.com/slang25) in [spectreconsole/spectre.console#1289 - Update dependency SixLabors.ImageSharp to v3.1.3 by [@​renovate](https://togithub.com/renovate) in [spectreconsole/spectre.console#1486 - Positioned Progress Tasks - Before or After Other Tasks by [@​thomhurst](https://togithub.com/thomhurst) in [spectreconsole/spectre.console#1250 - Added NoStackTrace to ExceptionFormats by [@​gerardog](https://togithub.com/gerardog) in [spectreconsole/spectre.console#1489 - Pipe character for listing options (issue 1434) by [@​FrankRay78](https://togithub.com/FrankRay78) in [spectreconsole/spectre.console#1498 - Improve XmlDoc output by [@​yenneferofvengerberg](https://togithub.com/yenneferofvengerberg) in [spectreconsole/spectre.console#1503 - Revert [`71a5d83`](https://togithub.com/spectreconsole/spectre.console/commit/71a5d830) to undo flickering regression by [@​phil-scott-78](https://togithub.com/phil-scott-78) in [spectreconsole/spectre.console#1504 - AddDelegate uses an abstract type when used in a branch by [@​BlazeFace](https://togithub.com/BlazeFace) in [spectreconsole/spectre.console#1509 - Missing Separator When Headers are Hidden by [@​BlazeFace](https://togithub.com/BlazeFace) in [spectreconsole/spectre.console#1513 - Expose raw arguments on the command context by [@​patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1523 - Add token representation to remaining arguments by [@​patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1525 ##### New Contributors - [@​baronfel](https://togithub.com/baronfel) made their first contribution in [spectreconsole/spectre.console#1425 - [@​DarqueWarrior](https://togithub.com/DarqueWarrior) made their first contribution in [spectreconsole/spectre.console#1431 - [@​tonycknight](https://togithub.com/tonycknight) made their first contribution in [spectreconsole/spectre.console#1435 - [@​caesay](https://togithub.com/caesay) made their first contribution in [spectreconsole/spectre.console#1439 - [@​jsheely](https://togithub.com/jsheely) made their first contribution in [spectreconsole/spectre.console#1414 - [@​danielcweber](https://togithub.com/danielcweber) made their first contribution in [spectreconsole/spectre.console#1456 - [@​martincostello](https://togithub.com/martincostello) made their first contribution in [spectreconsole/spectre.console#1477 - [@​slang25](https://togithub.com/slang25) made their first contribution in [spectreconsole/spectre.console#1289 - [@​thomhurst](https://togithub.com/thomhurst) made their first contribution in [spectreconsole/spectre.console#1250 - [@​gerardog](https://togithub.com/gerardog) made their first contribution in [spectreconsole/spectre.console#1489 - [@​yenneferofvengerberg](https://togithub.com/yenneferofvengerberg) made their first contribution in [spectreconsole/spectre.console#1503 - [@​BlazeFace](https://togithub.com/BlazeFace) made their first contribution in [spectreconsole/spectre.console#1509 **Full Changelog**: spectreconsole/spectre.console@0.48.0...0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/buehler/dotnet-operator-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ian-buse
pushed a commit
to dh2i-devs/dotnet-operator-sdk
that referenced
this pull request
May 3, 2024
](https://renovatebot.com){kind=link}
…ehler#751) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Spectre.Console.Testing](https://togithub.com/spectreconsole/spectre.console) | `0.48.0` -> `0.49.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>spectreconsole/spectre.console (Spectre.Console.Testing)</summary> ### [`v0.49.0`](https://togithub.com/spectreconsole/spectre.console/releases/tag/0.49.0) [Compare Source](https://togithub.com/spectreconsole/spectre.console/compare/0.48.0...0.49.0) ##### What's Changed - Cleanup Line-Endings by [@​nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1381 - Added spectre.console.cli to quick-start. by [@​nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1413 - Fix rendering of ListPrompt for odd pageSizes by [@​nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1365 - Remove mandelbrot example due to conflicting license by [@​patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1426 - Allow specifying a property to ignore the use of build-time packages for versioning and analysis by [@​baronfel](https://togithub.com/baronfel) in [spectreconsole/spectre.console#1425 - Add the possibility to register multiple interceptors by [@​nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1412 - Added the ITypeResolver to the ExceptionHandler by [@​nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1411 - Updated typo in commandApp.md by [@​DarqueWarrior](https://togithub.com/DarqueWarrior) in [spectreconsole/spectre.console#1431 - Command with -v displays app version instead of executing the command by [@​FrankRay78](https://togithub.com/FrankRay78) in [spectreconsole/spectre.console#1427 - HelpProvider colors should be configurable by [@​FrankRay78](https://togithub.com/FrankRay78) in [spectreconsole/spectre.console#1408 - Direct contributors to the current CONTRIBUTING.md by [@​tonycknight](https://togithub.com/tonycknight) in [spectreconsole/spectre.console#1435 - Fix deadlock when cancelling prompts by [@​caesay](https://togithub.com/caesay) in [spectreconsole/spectre.console#1439 - Add progress bar value formatter by [@​jsheely](https://togithub.com/jsheely) in [spectreconsole/spectre.console#1414 - Update dependencies and do some clean-up by [@​patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1440 - Delete \[UsesVerify], which has become obsolete through the latest update. by [@​danielcweber](https://togithub.com/danielcweber) in [spectreconsole/spectre.console#1456 - Don't erase secret prompt text upon backspace when mask is null by [@​danielcweber](https://togithub.com/danielcweber) in [spectreconsole/spectre.console#1458 - Update dependencies to the latest version by [@​patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1459 - Automatically register command settings by [@​patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1463 - chore: Update dependency dotnet-example to v3.1.0 by [@​renovate](https://togithub.com/renovate) in [spectreconsole/spectre.console#1470 - chore: Update dependency Roslynator.Analyzers to v4.11.0 by [@​renovate](https://togithub.com/renovate) in [spectreconsole/spectre.console#1473 - Remove \[DebuggerDisplay] from Paragraph by [@​martincostello](https://togithub.com/martincostello) in [spectreconsole/spectre.console#1477 - Selection Prompt Search by [@​slang25](https://togithub.com/slang25) in [spectreconsole/spectre.console#1289 - Update dependency SixLabors.ImageSharp to v3.1.3 by [@​renovate](https://togithub.com/renovate) in [spectreconsole/spectre.console#1486 - Positioned Progress Tasks - Before or After Other Tasks by [@​thomhurst](https://togithub.com/thomhurst) in [spectreconsole/spectre.console#1250 - Added NoStackTrace to ExceptionFormats by [@​gerardog](https://togithub.com/gerardog) in [spectreconsole/spectre.console#1489 - Pipe character for listing options (issue 1434) by [@​FrankRay78](https://togithub.com/FrankRay78) in [spectreconsole/spectre.console#1498 - Improve XmlDoc output by [@​yenneferofvengerberg](https://togithub.com/yenneferofvengerberg) in [spectreconsole/spectre.console#1503 - Revert [`71a5d83`](https://togithub.com/spectreconsole/spectre.console/commit/71a5d830) to undo flickering regression by [@​phil-scott-78](https://togithub.com/phil-scott-78) in [spectreconsole/spectre.console#1504 - AddDelegate uses an abstract type when used in a branch by [@​BlazeFace](https://togithub.com/BlazeFace) in [spectreconsole/spectre.console#1509 - Missing Separator When Headers are Hidden by [@​BlazeFace](https://togithub.com/BlazeFace) in [spectreconsole/spectre.console#1513 - Expose raw arguments on the command context by [@​patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1523 - Add token representation to remaining arguments by [@​patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1525 ##### New Contributors - [@​baronfel](https://togithub.com/baronfel) made their first contribution in [spectreconsole/spectre.console#1425 - [@​DarqueWarrior](https://togithub.com/DarqueWarrior) made their first contribution in [spectreconsole/spectre.console#1431 - [@​tonycknight](https://togithub.com/tonycknight) made their first contribution in [spectreconsole/spectre.console#1435 - [@​caesay](https://togithub.com/caesay) made their first contribution in [spectreconsole/spectre.console#1439 - [@​jsheely](https://togithub.com/jsheely) made their first contribution in [spectreconsole/spectre.console#1414 - [@​danielcweber](https://togithub.com/danielcweber) made their first contribution in [spectreconsole/spectre.console#1456 - [@​martincostello](https://togithub.com/martincostello) made their first contribution in [spectreconsole/spectre.console#1477 - [@​slang25](https://togithub.com/slang25) made their first contribution in [spectreconsole/spectre.console#1289 - [@​thomhurst](https://togithub.com/thomhurst) made their first contribution in [spectreconsole/spectre.console#1250 - [@​gerardog](https://togithub.com/gerardog) made their first contribution in [spectreconsole/spectre.console#1489 - [@​yenneferofvengerberg](https://togithub.com/yenneferofvengerberg) made their first contribution in [spectreconsole/spectre.console#1503 - [@​BlazeFace](https://togithub.com/BlazeFace) made their first contribution in [spectreconsole/spectre.console#1509 **Full Changelog**: spectreconsole/spectre.console@0.48.0...0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/buehler/dotnet-operator-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1077
fixes #1076
Changes
Because
ReadKeyAsyncreturns null if the cancellationToken is cancelled, this creates infinite loops in theAnsiConsoleExtensions.ReadLinemethod and theListPrompt.Showmethod.