Don't erase secret prompt text upon backspace when mask is null #1458

danielcweber · 2024-02-12T20:05:19Z

Note: This builds upon an ealier PR that I made because it wouldn't build otherwise. I will rebase this PR accordingly.

[X ] I have read the Contribution Guidelines
[X ] I have commented on the issue above and discussed the intended changes
A maintainer has signed off on the changes and the issue was assigned to me
[X ] All newly added code is adequately covered by tests
[X ] All existing tests are still running without errors
[X ] The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

…a null mask.

patriksvensson · 2024-02-13T08:01:29Z

Merged! Thank you for your contribution. Much appreciated! 👍

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Spectre.Console.Testing](https://togithub.com/spectreconsole/spectre.console) | `0.48.0` -> `0.49.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Spectre.Console.Testing/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Spectre.Console.Testing/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Spectre.Console.Testing/0.48.0/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Spectre.Console.Testing/0.48.0/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>spectreconsole/spectre.console (Spectre.Console.Testing)</summary> ### [`v0.49.0`](https://togithub.com/spectreconsole/spectre.console/releases/tag/0.49.0) [Compare Source](https://togithub.com/spectreconsole/spectre.console/compare/0.48.0...0.49.0) ##### What's Changed - Cleanup Line-Endings by [@nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1381 - Added spectre.console.cli to quick-start. by [@nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1413 - Fix rendering of ListPrompt for odd pageSizes by [@nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1365 - Remove mandelbrot example due to conflicting license by [@patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1426 - Allow specifying a property to ignore the use of build-time packages for versioning and analysis by [@baronfel](https://togithub.com/baronfel) in [spectreconsole/spectre.console#1425 - Add the possibility to register multiple interceptors by [@nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1412 - Added the ITypeResolver to the ExceptionHandler by [@nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1411 - Updated typo in commandApp.md by [@DarqueWarrior](https://togithub.com/DarqueWarrior) in [spectreconsole/spectre.console#1431 - Command with -v displays app version instead of executing the command by [@FrankRay78](https://togithub.com/FrankRay78) in [spectreconsole/spectre.console#1427 - HelpProvider colors should be configurable by [@FrankRay78](https://togithub.com/FrankRay78) in [spectreconsole/spectre.console#1408 - Direct contributors to the current CONTRIBUTING.md by [@tonycknight](https://togithub.com/tonycknight) in [spectreconsole/spectre.console#1435 - Fix deadlock when cancelling prompts by [@caesay](https://togithub.com/caesay) in [spectreconsole/spectre.console#1439 - Add progress bar value formatter by [@jsheely](https://togithub.com/jsheely) in [spectreconsole/spectre.console#1414 - Update dependencies and do some clean-up by [@patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1440 - Delete \[UsesVerify], which has become obsolete through the latest update. by [@danielcweber](https://togithub.com/danielcweber) in [spectreconsole/spectre.console#1456 - Don't erase secret prompt text upon backspace when mask is null by [@danielcweber](https://togithub.com/danielcweber) in [spectreconsole/spectre.console#1458 - Update dependencies to the latest version by [@patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1459 - Automatically register command settings by [@patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1463 - chore: Update dependency dotnet-example to v3.1.0 by [@renovate](https://togithub.com/renovate) in [spectreconsole/spectre.console#1470 - chore: Update dependency Roslynator.Analyzers to v4.11.0 by [@renovate](https://togithub.com/renovate) in [spectreconsole/spectre.console#1473 - Remove \[DebuggerDisplay] from Paragraph by [@martincostello](https://togithub.com/martincostello) in [spectreconsole/spectre.console#1477 - Selection Prompt Search by [@slang25](https://togithub.com/slang25) in [spectreconsole/spectre.console#1289 - Update dependency SixLabors.ImageSharp to v3.1.3 by [@renovate](https://togithub.com/renovate) in [spectreconsole/spectre.console#1486 - Positioned Progress Tasks - Before or After Other Tasks by [@thomhurst](https://togithub.com/thomhurst) in [spectreconsole/spectre.console#1250 - Added NoStackTrace to ExceptionFormats by [@gerardog](https://togithub.com/gerardog) in [spectreconsole/spectre.console#1489 - Pipe character for listing options (issue 1434) by [@FrankRay78](https://togithub.com/FrankRay78) in [spectreconsole/spectre.console#1498 - Improve XmlDoc output by [@yenneferofvengerberg](https://togithub.com/yenneferofvengerberg) in [spectreconsole/spectre.console#1503 - Revert [`71a5d83`](https://togithub.com/spectreconsole/spectre.console/commit/71a5d830) to undo flickering regression by [@phil-scott-78](https://togithub.com/phil-scott-78) in [spectreconsole/spectre.console#1504 - AddDelegate uses an abstract type when used in a branch by [@BlazeFace](https://togithub.com/BlazeFace) in [spectreconsole/spectre.console#1509 - Missing Separator When Headers are Hidden by [@BlazeFace](https://togithub.com/BlazeFace) in [spectreconsole/spectre.console#1513 - Expose raw arguments on the command context by [@patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1523 - Add token representation to remaining arguments by [@patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1525 ##### New Contributors - [@baronfel](https://togithub.com/baronfel) made their first contribution in [spectreconsole/spectre.console#1425 - [@DarqueWarrior](https://togithub.com/DarqueWarrior) made their first contribution in [spectreconsole/spectre.console#1431 - [@tonycknight](https://togithub.com/tonycknight) made their first contribution in [spectreconsole/spectre.console#1435 - [@caesay](https://togithub.com/caesay) made their first contribution in [spectreconsole/spectre.console#1439 - [@jsheely](https://togithub.com/jsheely) made their first contribution in [spectreconsole/spectre.console#1414 - [@danielcweber](https://togithub.com/danielcweber) made their first contribution in [spectreconsole/spectre.console#1456 - [@martincostello](https://togithub.com/martincostello) made their first contribution in [spectreconsole/spectre.console#1477 - [@slang25](https://togithub.com/slang25) made their first contribution in [spectreconsole/spectre.console#1289 - [@thomhurst](https://togithub.com/thomhurst) made their first contribution in [spectreconsole/spectre.console#1250 - [@gerardog](https://togithub.com/gerardog) made their first contribution in [spectreconsole/spectre.console#1489 - [@yenneferofvengerberg](https://togithub.com/yenneferofvengerberg) made their first contribution in [spectreconsole/spectre.console#1503 - [@BlazeFace](https://togithub.com/BlazeFace) made their first contribution in [spectreconsole/spectre.console#1509 **Full Changelog**: spectreconsole/spectre.console@0.48.0...0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/buehler/dotnet-operator-sdk).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ehler#751) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Spectre.Console.Testing](https://togithub.com/spectreconsole/spectre.console) | `0.48.0` -> `0.49.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Spectre.Console.Testing/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Spectre.Console.Testing/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Spectre.Console.Testing/0.48.0/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Spectre.Console.Testing/0.48.0/0.49.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>spectreconsole/spectre.console (Spectre.Console.Testing)</summary> ### [`v0.49.0`](https://togithub.com/spectreconsole/spectre.console/releases/tag/0.49.0) [Compare Source](https://togithub.com/spectreconsole/spectre.console/compare/0.48.0...0.49.0) ##### What's Changed - Cleanup Line-Endings by [@nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1381 - Added spectre.console.cli to quick-start. by [@nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1413 - Fix rendering of ListPrompt for odd pageSizes by [@nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1365 - Remove mandelbrot example due to conflicting license by [@patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1426 - Allow specifying a property to ignore the use of build-time packages for versioning and analysis by [@baronfel](https://togithub.com/baronfel) in [spectreconsole/spectre.console#1425 - Add the possibility to register multiple interceptors by [@nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1412 - Added the ITypeResolver to the ExceptionHandler by [@nils-a](https://togithub.com/nils-a) in [spectreconsole/spectre.console#1411 - Updated typo in commandApp.md by [@DarqueWarrior](https://togithub.com/DarqueWarrior) in [spectreconsole/spectre.console#1431 - Command with -v displays app version instead of executing the command by [@FrankRay78](https://togithub.com/FrankRay78) in [spectreconsole/spectre.console#1427 - HelpProvider colors should be configurable by [@FrankRay78](https://togithub.com/FrankRay78) in [spectreconsole/spectre.console#1408 - Direct contributors to the current CONTRIBUTING.md by [@tonycknight](https://togithub.com/tonycknight) in [spectreconsole/spectre.console#1435 - Fix deadlock when cancelling prompts by [@caesay](https://togithub.com/caesay) in [spectreconsole/spectre.console#1439 - Add progress bar value formatter by [@jsheely](https://togithub.com/jsheely) in [spectreconsole/spectre.console#1414 - Update dependencies and do some clean-up by [@patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1440 - Delete \[UsesVerify], which has become obsolete through the latest update. by [@danielcweber](https://togithub.com/danielcweber) in [spectreconsole/spectre.console#1456 - Don't erase secret prompt text upon backspace when mask is null by [@danielcweber](https://togithub.com/danielcweber) in [spectreconsole/spectre.console#1458 - Update dependencies to the latest version by [@patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1459 - Automatically register command settings by [@patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1463 - chore: Update dependency dotnet-example to v3.1.0 by [@renovate](https://togithub.com/renovate) in [spectreconsole/spectre.console#1470 - chore: Update dependency Roslynator.Analyzers to v4.11.0 by [@renovate](https://togithub.com/renovate) in [spectreconsole/spectre.console#1473 - Remove \[DebuggerDisplay] from Paragraph by [@martincostello](https://togithub.com/martincostello) in [spectreconsole/spectre.console#1477 - Selection Prompt Search by [@slang25](https://togithub.com/slang25) in [spectreconsole/spectre.console#1289 - Update dependency SixLabors.ImageSharp to v3.1.3 by [@renovate](https://togithub.com/renovate) in [spectreconsole/spectre.console#1486 - Positioned Progress Tasks - Before or After Other Tasks by [@thomhurst](https://togithub.com/thomhurst) in [spectreconsole/spectre.console#1250 - Added NoStackTrace to ExceptionFormats by [@gerardog](https://togithub.com/gerardog) in [spectreconsole/spectre.console#1489 - Pipe character for listing options (issue 1434) by [@FrankRay78](https://togithub.com/FrankRay78) in [spectreconsole/spectre.console#1498 - Improve XmlDoc output by [@yenneferofvengerberg](https://togithub.com/yenneferofvengerberg) in [spectreconsole/spectre.console#1503 - Revert [`71a5d83`](https://togithub.com/spectreconsole/spectre.console/commit/71a5d830) to undo flickering regression by [@phil-scott-78](https://togithub.com/phil-scott-78) in [spectreconsole/spectre.console#1504 - AddDelegate uses an abstract type when used in a branch by [@BlazeFace](https://togithub.com/BlazeFace) in [spectreconsole/spectre.console#1509 - Missing Separator When Headers are Hidden by [@BlazeFace](https://togithub.com/BlazeFace) in [spectreconsole/spectre.console#1513 - Expose raw arguments on the command context by [@patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1523 - Add token representation to remaining arguments by [@patriksvensson](https://togithub.com/patriksvensson) in [spectreconsole/spectre.console#1525 ##### New Contributors - [@baronfel](https://togithub.com/baronfel) made their first contribution in [spectreconsole/spectre.console#1425 - [@DarqueWarrior](https://togithub.com/DarqueWarrior) made their first contribution in [spectreconsole/spectre.console#1431 - [@tonycknight](https://togithub.com/tonycknight) made their first contribution in [spectreconsole/spectre.console#1435 - [@caesay](https://togithub.com/caesay) made their first contribution in [spectreconsole/spectre.console#1439 - [@jsheely](https://togithub.com/jsheely) made their first contribution in [spectreconsole/spectre.console#1414 - [@danielcweber](https://togithub.com/danielcweber) made their first contribution in [spectreconsole/spectre.console#1456 - [@martincostello](https://togithub.com/martincostello) made their first contribution in [spectreconsole/spectre.console#1477 - [@slang25](https://togithub.com/slang25) made their first contribution in [spectreconsole/spectre.console#1289 - [@thomhurst](https://togithub.com/thomhurst) made their first contribution in [spectreconsole/spectre.console#1250 - [@gerardog](https://togithub.com/gerardog) made their first contribution in [spectreconsole/spectre.console#1489 - [@yenneferofvengerberg](https://togithub.com/yenneferofvengerberg) made their first contribution in [spectreconsole/spectre.console#1503 - [@BlazeFace](https://togithub.com/BlazeFace) made their first contribution in [spectreconsole/spectre.console#1509 **Full Changelog**: spectreconsole/spectre.console@0.48.0...0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/buehler/dotnet-operator-sdk).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

danielcweber changed the title ~~Dont erase prompt text~~ Dont erase secret prompt text upon backspace when mask is null Feb 12, 2024

danielcweber changed the title ~~Dont erase secret prompt text upon backspace when mask is null~~ Don't erase secret prompt text upon backspace when mask is null Feb 12, 2024

patriksvensson approved these changes Feb 13, 2024

View reviewed changes

Don't erase the prompt text when backspacing on a secret prompt with …

b6f9e45

…a null mask.

patriksvensson force-pushed the DontErasePromptText branch from 9be46f4 to b6f9e45 Compare February 13, 2024 07:58

patriksvensson merged commit bf3b91a into spectreconsole:main Feb 13, 2024
3 checks passed

danielcweber deleted the DontErasePromptText branch February 13, 2024 08:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't erase secret prompt text upon backspace when mask is null #1458

Don't erase secret prompt text upon backspace when mask is null #1458

danielcweber commented Feb 12, 2024 •

edited

patriksvensson commented Feb 13, 2024

Don't erase secret prompt text upon backspace when mask is null #1458

Don't erase secret prompt text upon backspace when mask is null #1458

Conversation

danielcweber commented Feb 12, 2024 • edited

Changes

patriksvensson commented Feb 13, 2024

danielcweber commented Feb 12, 2024 •

edited