Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiles: Trigger UsernameChanged event when setting username #7

Closed
kmarius opened this issue Sep 19, 2020 · 2 comments
Closed

profiles: Trigger UsernameChanged event when setting username #7

kmarius opened this issue Sep 19, 2020 · 2 comments

Comments

@kmarius
Copy link

kmarius commented Sep 19, 2020

As the title says. The official farming timer plugin and the bitwarden plugin from the plugin hub subscribe to this event. I have confirmed both to be working as expected with the necessary changes. I could make a PR, but not with the version with password support.
@kmarius
Copy link
Author

kmarius commented Sep 20, 2020

I have prepared a working version here: https://github.com/kmarius/runelite-plugins/tree/profiles

@kmarius
Copy link
Author

kmarius commented Jan 11, 2021

The event is now automatically fired after setting username.

@kmarius kmarius closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmarius