Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed method description in recipes #961

Closed
kehanlu opened this issue Aug 28, 2021 · 4 comments
Closed

More detailed method description in recipes #961

kehanlu opened this issue Aug 28, 2021 · 4 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@kehanlu
Copy link

kehanlu commented Aug 28, 2021

Hi,
I found in many recipes, the descriptions did not reveal full methods they used in the recipe. Make it difficult to make reasonable comparison with other toolkits or methods in a glance.

For example, in recipes/AISHELL-1/ASR/transformer, the reported results in both recipes used spec augmentation and rirs noise augmentation to improve the error rates, but did not specify in README.md. Anyone who wants to know what they really do have to read the code and hparams file by themselves.

I suggest that we can design some guide for contributors to report their recipes. For example paper they implemented, augmentation method they used or other detailed config such as kernel size, training epochs etc.

@TParcollet
Copy link
Collaborator

@mravanelli what do you think ?

@mravanelli
Copy link
Collaborator

mravanelli commented Aug 30, 2021 via email

@Adel-Moumen Adel-Moumen added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 6, 2022
@Adel-Moumen Adel-Moumen added the good first issue Good for newcomers label Oct 6, 2022
@Adel-Moumen
Copy link
Collaborator

Hey,

I think we could create a template for README.md with a section describing the systems.. what do you think?

Best.

@Noel6161131110
Copy link

Hey there,

should we edit on the existing readme..😀

@speechbrain speechbrain locked and limited conversation to collaborators Mar 28, 2024
@Adel-Moumen Adel-Moumen converted this issue into discussion #2479 Mar 28, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants