Skip to content

version: the build tag is incorrectly added to the RocksDB version string #231

Description

@isaac-io

The changes in #156 were accidentally applied to the GetRocksVersionAsString() function instead of GetSpeedbVersionAsString(). This replaced ROCKSDB_PATCH with SPEEDB_PATCH (causing 7.2.2 to become 7.2.0), as well as added the tag in the wrong place (Speedb version: 2.1.0 (7.2.0-*-(main+4)-(#isaac/snapshot+1)) instead of Speedb version: 2.1.0-*-(main+4)-(#isaac/snapshot+1) (7.2.2)).

To Reproduce

  1. Build db_bench on any branch containing build: add a build tag into the version for non-release builds #156
  2. Run it and see the log file

Expected behavior

The RocksDB version patch isn't replaced, and the tag is applied to the Speedb version rather than the RocksDB one.

Additional context

N/A

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingbuildBuild related

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions