New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedb Artifacts #64

Closed

bosmatt opened this issue Jul 24, 2022 · 3 comments · Fixed by #66

Assignees

Labels

Milestone

Contributor

bosmatt commented Jul 24, 2022

Artifacts from a Speedb build (JAR, Libraries, etc) will include the Speedb name (e.g. libspeedb.a)
Installation packages (CMake packages, Maven artifactory, apt/yum installers, etc) will include "Speedb"
The Usage/Version of the library and executables will refer to Speedb

bosmatt assigned osnatbm

osnatbm assigned isaac-io and osnatbm and unassigned osnatbm

Contributor

isaac-io commented Jul 25, 2022

What about the include/ directory? Do we need to do anything about the C++/Java namespace? Is there a drop-in replacement path where the library is named rocksdb?

osnatbm commented Jul 25, 2022

Artifacts from a Speedb build (JAR, Libraries, etc) will include the Speedb name (e.g. libspeedb.a)
User: Instead of linking their application against librocksdb.a, they will need to change it to link against libspeed.a. For Java, the package they use in their build/deploy scripts will change. The amount of work depends on the tool, but is generally pretty low
Speedb: We will need update the Makefile et al to produce the appropriate binaries
Installation packages (CMake packages, Maven artifactory, apt/yum installers, etc) will include be "Speedb"
User: CMake: The user would find a different package (speedb instead of rocksdb). We might be able to make the rest "just work", but I am not positive. It might mean that their CMake scripts have to refer to speedb instead of rocksdb. Maven: they would point at a different repository in the Maven artifactory. I am not exactly sure how this works but think it is straightforward.
Speedb: We need to understand how the install process works and be sure to build/push the right artifacts.
The Usage/Version of the library and executables will refer to Speedb, not RocksDB
User: No impact unless their scripts comb the values looking for strings.
Speedb: Development/QA time to make sure it works for all executables

-Change readme and relevant user guides (getting started and maybe how to contribute)

osnatbm removed their assignment

isaac-io added a commit that referenced this issue


          build: rename artefacts and build config from RocksDB to Speedb (#64)

This includes both the CMake and Makefile configurations, various scripts
that are invoked during the build or during test runs, as well as the
Java native library loader code.

Note that this also renames all build configuration variables that refer
to RocksDB from ROCKSDB_* to SPEEDB_* (e.g. ROCKSDB_LITE is now SPEEDB_LITE).

isaac-io added a commit that referenced this issue


          scripts: rename RocksDB references to Speedb (#64)

8a80636

This includes simple renaming from `rocksdb` to `speedb` as well as replacing
URLs that are pointing to the RocksDB repository with the URL of the Speedb
repository.

isaac-io added a commit that referenced this issue


          general: replace RocksDB references in strings with Speedb (#64)

ec5b847

This includes references in statuses as well as tools output.

isaac-io added a commit that referenced this issue


          tools: replace RocksDB version information with the Speedb version (#64)

73f7ff2

This is done across all tools except trace_replay, which specifically
looks for the RocksDB version for database compatibility checks.

isaac-io linked a pull request

that will close this issue

#64: Speedb artifacts #66

Merged

isaac-io mentioned this issue

#64: Speedb artifacts #66

Merged

isaac-io added a commit that referenced this issue


          build: rename artefacts and build config from RocksDB to Speedb (#64)

a8c618d

This includes both the CMake and Makefile configurations, various scripts
that are invoked during the build or during test runs, as well as the
Java native library loader code.

Note that this also renames all build configuration variables that refer
to RocksDB from ROCKSDB_* to SPEEDB_* (e.g. ROCKSDB_LITE is now SPEEDB_LITE).

isaac-io added a commit that referenced this issue


          scripts: rename RocksDB references to Speedb (#64)

ff2f8f7

This includes simple renaming from `rocksdb` to `speedb` as well as replacing
URLs that are pointing to the RocksDB repository with the URL of the Speedb
repository.

isaac-io added a commit that referenced this issue


          general: replace RocksDB references in strings with Speedb (#64)

b3cf6d0

This includes references in statuses as well as tools output.

isaac-io added a commit that referenced this issue


          tools: replace RocksDB version information with the Speedb version (#64)

f19fb7e

This is done across all tools except trace_replay, which specifically
looks for the RocksDB version for database compatibility checks.

isaac-io added the enhancement label

isaac-io added a commit that referenced this issue


          build: rename artefacts and build config from RocksDB to Speedb (#64)

25b4f8d

This includes both the CMake and Makefile configurations, various scripts
that are invoked during the build or during test runs, as well as the
Java native library loader code.

Note that this also renames all build configuration variables that refer
to RocksDB from ROCKSDB_* to SPEEDB_* (e.g. ROCKSDB_LITE is now SPEEDB_LITE).

isaac-io added a commit that referenced this issue


          scripts: rename RocksDB references to Speedb (#64)

7c6f929

This includes simple renaming from `rocksdb` to `speedb` as well as replacing
URLs that are pointing to the RocksDB repository with the URL of the Speedb
repository.

isaac-io added a commit that referenced this issue


          general: replace RocksDB references in strings with Speedb (#64)

16e117f

This includes references in statuses as well as tools output.

isaac-io added a commit that referenced this issue


          tools: replace RocksDB version information with the Speedb version (#64)

1f0c677

This is done across all tools except trace_replay, which specifically
looks for the RocksDB version for database compatibility checks.

isaac-io added a commit that referenced this issue


          build: rename artefacts and build config from RocksDB to Speedb (#64)

This includes both the CMake and Makefile configurations, various scripts
that are invoked during the build or during test runs, as well as the
Java native library loader code.

Note that this also renames all build configuration variables that refer
to RocksDB from ROCKSDB_* to SPEEDB_* (e.g. ROCKSDB_LITE is now SPEEDB_LITE).

isaac-io added a commit that referenced this issue


          scripts: rename RocksDB references to Speedb (#64)

This includes simple renaming from `rocksdb` to `speedb` as well as replacing
URLs that are pointing to the RocksDB repository with the URL of the Speedb
repository.

isaac-io added a commit that referenced this issue


          general: replace RocksDB references in strings with Speedb (#64)

d152e6d

This includes references in statuses as well as tools output.

isaac-io added a commit that referenced this issue


          tools: replace RocksDB version information with the Speedb version (#64)

5520d41

This is done across all tools except trace_replay, which specifically
looks for the RocksDB version for database compatibility checks.

isaac-io added a commit that referenced this issue


          build: rename artefacts and build config from RocksDB to Speedb (#64)

e1c318c

This includes both the CMake and Makefile configurations, various scripts
that are invoked during the build or during test runs, as well as the
Java native library loader code.

Note that this also renames all build configuration variables that refer
to RocksDB from ROCKSDB_* to SPEEDB_* (e.g. ROCKSDB_LITE is now SPEEDB_LITE).

isaac-io added a commit that referenced this issue


          scripts: rename RocksDB references to Speedb (#64)

68aab5f

This includes simple renaming from `rocksdb` to `speedb` as well as replacing
URLs that are pointing to the RocksDB repository with the URL of the Speedb
repository.

isaac-io added a commit that referenced this issue


          general: replace RocksDB references in strings with Speedb (#64)

67ba862

This includes references in statuses as well as tools output.

isaac-io added a commit that referenced this issue


          tools: replace RocksDB version information with the Speedb version (#64)

0c4a6a5

This is done across all tools except trace_replay, which specifically
looks for the RocksDB version for database compatibility checks.

Yuval-Ariel pushed a commit that referenced this issue


          build: rename artefacts from RocksDB to Speedb (#64)

5fd18de

This includes both the CMake and Makefile configurations, various scripts
that are invoked during the build or during test runs, as well as the
Java native library loader code.

Yuval-Ariel pushed a commit that referenced this issue


          scripts: rename RocksDB references to Speedb (#64)

8b35131

This includes simple renaming from `rocksdb` to `speedb` as well as replacing
URLs that are pointing to the RocksDB repository with the URL of the Speedb
repository.

Yuval-Ariel pushed a commit that referenced this issue


          general: replace RocksDB references in strings with Speedb (#64)

acb4295

This includes references in statuses as well as tools output.

Yuval-Ariel pushed a commit that referenced this issue


          tools: replace RocksDB version information with the Speedb version (#64)

c166b4a

This is done across all tools except trace_replay, which specifically
looks for the RocksDB version for database compatibility checks.

Yuval-Ariel added a commit that referenced this issue


          Rebase 8.1.1: reintroduce preserve_unverified_changes

7a169a2

which was accidentally removed in
general: replace RocksDB references in strings with Speedb (#64)

Yuval-Ariel pushed a commit that referenced this issue


          build: clean up the build configuration to allow rebranding (#64)

94df4ed

This updates the CMake and Makefile configuration and related scripts to
use variables where possible and avoid explicit references to RocksDB in
order to allow rebranding of the output artefacts.

Yuval-Ariel pushed a commit that referenced this issue


          build: rename artefacts from RocksDB to Speedb (#64)

3fe5bdb

This includes both the CMake and Makefile configurations, various scripts
that are invoked during the build or during test runs, as well as the
Java native library loader code.

Yuval-Ariel pushed a commit that referenced this issue


          scripts: rename RocksDB references to Speedb (#64)

f1fd855

This includes simple renaming from `rocksdb` to `speedb` as well as replacing
URLs that are pointing to the RocksDB repository with the URL of the Speedb
repository.

Yuval-Ariel pushed a commit that referenced this issue


          general: replace RocksDB references in strings with Speedb (#64)

ffe4885

This includes references in statuses as well as tools output.

Yuval-Ariel pushed a commit that referenced this issue


          tools: replace RocksDB version information with the Speedb version (#64)

3af146b

This is done across all tools except trace_replay, which specifically
looks for the RocksDB version for database compatibility checks.

Yuval-Ariel added a commit that referenced this issue


          Rebase 8.1.1: reintroduce preserve_unverified_changes

b088644

which was accidentally removed in
general: replace RocksDB references in strings with Speedb (#64)

udi-speedb pushed a commit that referenced this issue


          SPDB-347: Add a version number to our builds

7de51e5

The change set includes:
1) A header file that contains the Major, Minor, and Patch versions of speedb
as a macro, as well as a set of functions returning info about how/when/where
this version of speedb was created.

also includes all changes done on build_version.cc.in in the following commits:
1. version: remove superfluous build property
The `speedb_build_spdb_key` property is unused and was accidentally
imported as part of #1.

2.general: replace RocksDB references in strings with Speedb (#64)
This includes references in statuses as well as tools output.

udi-speedb pushed a commit that referenced this issue


          build: rename artefacts from RocksDB to Speedb (#64)

1ff326b

This includes both the CMake and Makefile configurations, various scripts
that are invoked during the build or during test runs, as well as the
Java native library loader code.

udi-speedb pushed a commit that referenced this issue


          scripts: rename RocksDB references to Speedb (#64)

ed4c6b4

This includes simple renaming from `rocksdb` to `speedb` as well as replacing
URLs that are pointing to the RocksDB repository with the URL of the Speedb
repository.

udi-speedb pushed a commit that referenced this issue


          general: replace RocksDB references in strings with Speedb (#64)

e90f1e1

This includes references in statuses as well as tools output.

udi-speedb pushed a commit that referenced this issue


          tools: replace RocksDB version information with the Speedb version (#64)

71c4524

This is done across all tools except trace_replay, which specifically
looks for the RocksDB version for database compatibility checks.

udi-speedb pushed a commit that referenced this issue


          Rebase 8.1.1: reintroduce preserve_unverified_changes

a4f0612

which was accidentally removed in
general: replace RocksDB references in strings with Speedb (#64)

udi-speedb pushed a commit that referenced this issue


          build: clean up the build configuration to allow rebranding (#64)

eb24487

This updates the CMake and Makefile configuration and related scripts to
use variables where possible and avoid explicit references to RocksDB in
order to allow rebranding of the output artefacts.

udi-speedb pushed a commit that referenced this issue


          build: rename artefacts from RocksDB to Speedb (#64)

e90ab42

This includes both the CMake and Makefile configurations, various scripts
that are invoked during the build or during test runs, as well as the
Java native library loader code.

udi-speedb pushed a commit that referenced this issue


          scripts: rename RocksDB references to Speedb (#64)

cd3b965

This includes simple renaming from `rocksdb` to `speedb` as well as replacing
URLs that are pointing to the RocksDB repository with the URL of the Speedb
repository.

udi-speedb pushed a commit that referenced this issue


          general: replace RocksDB references in strings with Speedb (#64)

48b66e3

This includes references in statuses as well as tools output.

udi-speedb pushed a commit that referenced this issue


          tools: replace RocksDB version information with the Speedb version (#64)

bc8d56d

This is done across all tools except trace_replay, which specifically
looks for the RocksDB version for database compatibility checks.

udi-speedb pushed a commit that referenced this issue


          Rebase 8.1.1: reintroduce preserve_unverified_changes

94b0fba

which was accidentally removed in
general: replace RocksDB references in strings with Speedb (#64)

udi-speedb pushed a commit that referenced this issue


          SPDB-347: Add a version number to our builds

f52ae6b

The change set includes:
1) A header file that contains the Major, Minor, and Patch versions of speedb
as a macro, as well as a set of functions returning info about how/when/where
this version of speedb was created.

also includes all changes done on build_version.cc.in in the following commits:
1. version: remove superfluous build property
The `speedb_build_spdb_key` property is unused and was accidentally
imported as part of #1.

2.general: replace RocksDB references in strings with Speedb (#64)
This includes references in statuses as well as tools output.

udi-speedb pushed a commit that referenced this issue


          build: clean up the build configuration to allow rebranding (#64)

This updates the CMake and Makefile configuration and related scripts to
use variables where possible and avoid explicit references to RocksDB in
order to allow rebranding of the output artefacts.

udi-speedb pushed a commit that referenced this issue


          build: rename artefacts from RocksDB to Speedb (#64)

45cf320

This includes both the CMake and Makefile configurations, various scripts
that are invoked during the build or during test runs, as well as the
Java native library loader code.

udi-speedb pushed a commit that referenced this issue


          scripts: rename RocksDB references to Speedb (#64)

7c89a21

This includes simple renaming from `rocksdb` to `speedb` as well as replacing
URLs that are pointing to the RocksDB repository with the URL of the Speedb
repository.

udi-speedb pushed a commit that referenced this issue


          general: replace RocksDB references in strings with Speedb (#64)

cde3ba9

This includes references in statuses as well as tools output.

udi-speedb pushed a commit that referenced this issue


          tools: replace RocksDB version information with the Speedb version (#64)

64550e4

This is done across all tools except trace_replay, which specifically
looks for the RocksDB version for database compatibility checks.

udi-speedb pushed a commit that referenced this issue


          Rebase 8.1.1: reintroduce preserve_unverified_changes

42a04bb

which was accidentally removed in
general: replace RocksDB references in strings with Speedb (#64)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment