"nice to have" additional info #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was my understanding that we wanted to hold off the integration of SPDB-434 (the make check scripts) until we find that we actually need them. Was there a decision to include them anyway? Also, I think cf613ca needs to be reworded. It doesn't do any whitespace normalisation anymore, and the only cleanup it does is making the comparison of the |
Yuval-Ariel
force-pushed
the
yuval/722-infrast-add_info
branch
from
ccbdbe7
to
cb5b7eb
Compare
isaac-io
suggested changes
Jun 20, 2022
Yuval-Ariel
force-pushed
the
yuval/722-infrast-add_info
branch
2 times, most recently
from
6ed110f
to
717d4d9
Compare
isaac-io
approved these changes
Jun 22, 2022
Yuval-Ariel
assigned assaf-speedb and Yuval-Ariel and unassigned Yuval-Ariel and assaf-speedb
udi-speedb
added a commit
that referenced
this pull request
Jun 26, 2022
udi-speedb
added a commit
that referenced
this pull request
Jun 29, 2022
The change set includes: 1) A header file that contains the Major, Minor, and Patch versions of speedb as a macro, as well as a set of functions returning info about how/when/where this version of speedb was created.
as changes to it are either version updates or fixing compiler errors.
Yuval-Ariel
force-pushed
the
yuval/722-infrast-add_info
branch
from
46142a2
to
c1db45e
Compare
isaac-io
added a commit
that referenced
this pull request
Jul 28, 2022
The `speedb_build_spdb_key` property is unused and was accidentally imported as part of #1.
udi-speedb
added a commit
that referenced
this pull request
Sep 28, 2022
udi-speedb
added a commit
that referenced
this pull request
Sep 29, 2022
udi-speedb
added a commit
that referenced
this pull request
Nov 15, 2022
Yuval-Ariel
added a commit
that referenced
this pull request
Nov 23, 2022
The change set includes: 1) A header file that contains the Major, Minor, and Patch versions of speedb as a macro, as well as a set of functions returning info about how/when/where this version of speedb was created. also includes all changes done on build_version.cc.in in the following commits: 1. version: remove superfluous build property The `speedb_build_spdb_key` property is unused and was accidentally imported as part of #1. 2.general: replace RocksDB references in strings with Speedb (#64) This includes references in statuses as well as tools output. 3.build: add a version build-tag for non-release builds (#156) The build tag can be set during the build (using either the Makefile or the CMake). If it's not provided, and we're not in a release build, it will be calculated using the state of the git tree since the last release tag (for example, for this PR the build tag will be calculated as `(main+17)-(156-build-add-a-build-tag-into-the-version-for-non-release-builds+1)`. If the git tree state can not be determined, a question mark will be used instead. build_version: apply the build tag to the Speedb version string (#231) 4. The changes in #157 were accidentally applied to the `GetRocksVersionAsString()` function instead of the `GetSpeedbVersionAsString()` function. This replaced the RocksDB patch number with the Speedb one, and added the build tag in the wrong place. Fix it by moving the logic to the intended function.
Yuval-Ariel
pushed a commit
that referenced
this pull request
Nov 25, 2022
The change set includes: 1) A header file that contains the Major, Minor, and Patch versions of speedb as a macro, as well as a set of functions returning info about how/when/where this version of speedb was created. also includes all changes done on build_version.cc.in in the following commits: 1. version: remove superfluous build property The `speedb_build_spdb_key` property is unused and was accidentally imported as part of #1. 2.general: replace RocksDB references in strings with Speedb (#64) This includes references in statuses as well as tools output.
udi-speedb
added a commit
that referenced
this pull request
Feb 13, 2023
udi-speedb
added a commit
that referenced
this pull request
Feb 16, 2023
udi-speedb
added a commit
that referenced
this pull request
Apr 2, 2023
Yuval-Ariel
pushed a commit
that referenced
this pull request
Apr 30, 2023
The change set includes: 1) A header file that contains the Major, Minor, and Patch versions of speedb as a macro, as well as a set of functions returning info about how/when/where this version of speedb was created. also includes all changes done on build_version.cc.in in the following commits: 1. version: remove superfluous build property The `speedb_build_spdb_key` property is unused and was accidentally imported as part of #1. 2.general: replace RocksDB references in strings with Speedb (#64) This includes references in statuses as well as tools output.
udi-speedb
added a commit
that referenced
this pull request
Aug 1, 2023
udi-speedb
added a commit
that referenced
this pull request
Aug 30, 2023
udi-speedb
added a commit
that referenced
this pull request
Aug 30, 2023
udi-speedb
added a commit
that referenced
this pull request
Aug 30, 2023
udi-speedb
added a commit
that referenced
this pull request
Aug 30, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Oct 31, 2023
The change set includes: 1) A header file that contains the Major, Minor, and Patch versions of speedb as a macro, as well as a set of functions returning info about how/when/where this version of speedb was created. also includes all changes done on build_version.cc.in in the following commits: 1. version: remove superfluous build property The `speedb_build_spdb_key` property is unused and was accidentally imported as part of #1. 2.general: replace RocksDB references in strings with Speedb (#64) This includes references in statuses as well as tools output.
udi-speedb
pushed a commit
that referenced
this pull request
Dec 1, 2023
The change set includes: 1) A header file that contains the Major, Minor, and Patch versions of speedb as a macro, as well as a set of functions returning info about how/when/where this version of speedb was created. also includes all changes done on build_version.cc.in in the following commits: 1. version: remove superfluous build property The `speedb_build_spdb_key` property is unused and was accidentally imported as part of #1. 2.general: replace RocksDB references in strings with Speedb (#64) This includes references in statuses as well as tools output.
udi-speedb
added a commit
that referenced
this pull request
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira ticket - https://speedb.atlassian.net/browse/SPDB-691