Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FieldComparator is not immutable #361

Closed
Pyknic opened this issue Mar 3, 2017 · 0 comments
Closed

FieldComparator is not immutable #361

Pyknic opened this issue Mar 3, 2017 · 0 comments
Assignees
@Pyknic
Labels
bug fixed
Projects
3.0.4 Forest
Milestone
3.0.4 Forest

Comments

@Pyknic
Copy link
Contributor

Pyknic commented Mar 3, 2017

When the FieldComparator.reversed() is called, it changes the state of the comparator instance. This can have some quite dangerous side effects when the comparator is used in the stream optimization process.
@Pyknic Pyknic added the bug label Mar 3, 2017
@Pyknic Pyknic added this to the 3.0.4 Forest milestone Mar 3, 2017
@Pyknic Pyknic self-assigned this Mar 3, 2017
@Pyknic Pyknic added this to In Progress in 3.0.4 Forest Mar 3, 2017
Pyknic added a commit that referenced this issue Mar 3, 2017
@Pyknic
runtime-field: Fix #361 Make all comparators immutable
20772f3
@minborg minborg moved this from In Progress to Ready in 3.0.4 Forest Mar 5, 2017
@minborg minborg added the fixed label Mar 5, 2017
@minborg minborg closed this as completed Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pyknic Pyknic

Labels
bug fixed
Projects
No open projects
3.0.4 Forest
Ready
Milestone
3.0.4 Forest
Development

No branches or pull requests
2 participants
@Pyknic @minborg