Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Join predicates so they use collations #600

Closed
minborg opened this issue Mar 5, 2018 · 1 comment
Closed

Check Join predicates so they use collations #600

minborg opened this issue Mar 5, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@minborg
Copy link
Contributor

minborg commented Mar 5, 2018

The join SQL predicate renderer might not use collations properly.

@minborg minborg added the bug label Mar 5, 2018
@minborg minborg added this to the 3.0.24 Forest milestone Mar 5, 2018
@minborg minborg self-assigned this Mar 5, 2018
@minborg minborg modified the milestones: 3.1.1 Homer, 3.1.2 Homer May 16, 2018
@minborg minborg added wontfix and removed bug labels Jun 21, 2018
@minborg
Copy link
Contributor Author

minborg commented Jun 21, 2018

Join predicates are not using String collation predicates and I propose that this is the way it should be. Normally a foreign key constrain between two String columns is setup using the default collation. So it is more likely to work as expected with the current solution. I am closing this issue.

@minborg minborg closed this as completed Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant