-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Analytics Tracking #58
Conversation
adds google analytics tracking using the async tracking snippet closes #57
Great idea! Only one tiny detail: we use camel case for variables in profiles, but you're adding a snake case here. Should we consolidate here? |
Force of habit, and a bit more in line with what SEO Tag Gem and other core friends of Jekyll are doing. But consistency is key. Updating. |
Actually. I'm going to renege my last comment. We should standardize on snake. I'm doing the research now. |
Here it is: https://github.com/bbatsov/ruby-style-guide#naming
Because Jekyll was born out of the Rails community, and enjoys many of the same Rails community tooling (e.g. Sprockets, etc.) we should standardize on lower snake. Additionally, the most popular Jekyll themes use lower snake for their configs, and individuals will be copying those. If we don't go lower snake we'll end up seeing configs in the wild sharing both, which nobody wants I'm sure. Lastly, users (like me) who intend to use SpeedTracker on CloudCannon will benefit from automatic spacing and pluralization of metadata when using lower snake case: https://docs.cloudcannon.com/editing/front-matter/ |
That's fine with me. As for changing |
Still looking for a merge on this. Please let me know if there is any actionable feedback. |
Sorry for the delay, been distracted with other things. I'll merge and release later today. |
Shamefully late, merged! |
adds google analytics tracking using the async tracking snippet
closes #57
https://developers.google.com/analytics/devguides/collection/analyticsjs/