Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align package.json with ESM module #1023

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

louisgv
Copy link
Contributor

@louisgv louisgv commented Jul 17, 2023

This is needed to import this package via some strict resolver that validate ESM package.json

@spencermountain
Copy link
Owner

hey thanks! I'm working on a release in the next day or two, and will include it in there.

@spencermountain spencermountain merged commit 38c57ea into spencermountain:master Jul 17, 2023
@louisgv louisgv deleted the patch-1 branch July 18, 2023 12:17
@spencermountain
Copy link
Owner

hey - do you think it'd be a problem for me to use both main and module?
hoping to avoid doing a major release. hard to keep up with this spec
cheers

spencermountain pushed a commit that referenced this pull request Jul 28, 2023
@louisgv
Copy link
Contributor Author

louisgv commented Jul 29, 2023

@spencermountain hey sorry for the late reply - I think it should be ok! The old CJS resolver only care for the main field and would ignore other :-?

@spencermountain spencermountain mentioned this pull request Aug 10, 2023
@spencermountain
Copy link
Owner

released as 14.10.0 - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants