Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email validation on 2fa wallet #2394

Closed
AbdussamadA opened this issue May 6, 2017 · 3 comments
Closed

Email validation on 2fa wallet #2394

AbdussamadA opened this issue May 6, 2017 · 3 comments

Comments

@AbdussamadA
Copy link
Contributor

Hi

Email validation for 2fa wallets is not good. I tried creating a wallet with an @localhost.k address and it caused the wallet creation/restoration process to crash with this message:

electrum_plugins.trustedcoin.trustedcoin.TrustedCoinException: Invalid request. Parameter 'email' is not a valid email.
@bauerj
Copy link
Collaborator

bauerj commented May 7, 2017

How would you expect that address to be validated?

@AbdussamadA
Copy link
Contributor Author

In this case checking that the TLD has more than one character would do it. But the bigger problem is the uncaught exception. Electrum should catch that and handle it gracefully instead of crashing outright.

@bauerj
Copy link
Collaborator

bauerj commented May 8, 2017

Okay, that makes sense.

@ecdsa ecdsa closed this as completed in d3918ef May 10, 2017
MrNaif2018 pushed a commit to MrNaif2018/electrum that referenced this issue Feb 7, 2022
@cculianu
Merge pull request spesmilo#2394 from emergent-reasons/py310_qt_fusio…
8822324 
…n_fixes

Update(s) to cashfusion qt for py310 removal of coercion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bauerj @AbdussamadA