Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: qt wizard should allow restoring from invalid bip39 seeds #8720

Closed
SomberNight opened this issue Dec 1, 2023 · 0 comments
Closed
Labels
bug 🐞 topic-wizard 🧙‍♂️ related to wallet creation/restore wizard
Milestone

Comments

@SomberNight
Copy link
Member

This is a regression in the new wizard -- the old wizard allowed this.
Specifically, we should allow any string to be used as a "bip39" seed, and enable the "next" button, but only in the desktop qt gui. The errors shown by the GUI (e.g. "incorrect checksum", "unknown wordlist") should be treated as soft-errors, basically just warnings.

See e.g. #6860

The reasoning for making the errors ignorable is that there are many wordlists for bip39 (typically one per natural language) and we don't include those (or can reliably tell which language the presented seed is). The checksum is only checked against the English list.

The reasoning for making a distinction between the qt desktop gui and the qml android gui, is that on Android we force the user to use our custom keyboard anyway, while on desktop the input method is unrestricted. Using the custom keyboard pretty much would indirectly limit the user to English seeds in any case.

@SomberNight SomberNight added this to the 4.5.0 milestone Dec 1, 2023
@SomberNight SomberNight added the topic-wizard 🧙‍♂️ related to wallet creation/restore wizard label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 topic-wizard 🧙‍♂️ related to wallet creation/restore wizard
Projects
None yet
Development

No branches or pull requests

1 participant