Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to deserialize the specific yaml file #1769

Closed
3 tasks done
richelieu-yang opened this issue Feb 23, 2024 · 3 comments
Closed
3 tasks done

Failed to deserialize the specific yaml file #1769

richelieu-yang opened this issue Feb 23, 2024 · 3 comments
Labels
kind/support Support requests for using the project

Comments

@richelieu-yang
Copy link

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I am not looking for support or already pursued the available support channels without success.
  • I have checked the troubleshooting guide for my problem, without success.

Viper Version

1.18.2

Go Version

1.19.13

Config Source

Defaults

Format

No response

Repl.it link

No response

Code reproducing the issue

package main

import (
	"fmt"
	"github.com/spf13/viper"
)

func main() {
	type bean struct {
		ResponseHeadersConfig map[string]string `json:"responseHeaders" yaml:"responseHeaders"`
	}

	b := &bean{}

	v := viper.New()
	v.SetConfigFile("_test.yaml")
	if err := v.ReadInConfig(); err != nil {
		panic(err)
	}
	err := v.Unmarshal(b)
	if err != nil {
		panic(err)
	}

	fmt.Println(b.ResponseHeadersConfig) // 
}

Expected Behavior

output

map[strict-transport-security:max-age=604800; includeSubDomains x-xss-protection:1;mode=block]

Actual Behavior

output

map[]

Steps To Reproduce

No response

Additional Information

_test.yaml

responseHeaders:
X-XSS-Protection: 1;mode=block
Strict-Transport-Security: max-age=604800; includeSubDomains

@richelieu-yang richelieu-yang added the kind/bug Something isn't working label Feb 23, 2024
Copy link

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@mazenharake
Copy link

Have you tried indentation in your _test.yaml file?

responseHeaders:
    X-XSS-Protection: 1;mode=block
    Strict-Transport-Security: max-age=604800; includeSubDomains

you should probably also use mapstructure:"responseHeaders" unless you changes the mapstructure package to use a different tag.

@sagikazarmark
Copy link
Collaborator

I think @mazenharake is correct: you need to use mapstructure struct tags.

@sagikazarmark sagikazarmark added kind/support Support requests for using the project and removed kind/bug Something isn't working labels Jun 5, 2024
@sagikazarmark sagikazarmark closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Support requests for using the project
Projects
None yet
Development

No branches or pull requests

3 participants