Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fsnotify improvements #1458

Merged
merged 1 commit into from Nov 4, 2022
Merged

Fsnotify improvements #1458

merged 1 commit into from Nov 4, 2022

Conversation

sagikazarmark
Copy link
Collaborator

@sagikazarmark sagikazarmark commented Nov 3, 2022

Fixes #610
Fixes #939

@sagikazarmark sagikazarmark added this to the v1.14.0 milestone Nov 3, 2022
@sagikazarmark sagikazarmark added the kind/enhancement New feature or request label Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

👋 Thanks for contributing to Viper! You are awesome! 🎉

A maintainer will take a look at your pull request shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@sagikazarmark sagikazarmark marked this pull request as draft Nov 3, 2022
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark marked this pull request as ready for review Nov 4, 2022
@sagikazarmark sagikazarmark merged commit 4b8d148 into master Nov 4, 2022
43 checks passed
@sagikazarmark sagikazarmark deleted the fsnotify-improvements branch Nov 4, 2022
jeff-mccoy pushed a commit to defenseunicorns/zarf that referenced this pull request Nov 8, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/spf13/viper](https://togithub.com/spf13/viper) | require |
minor | `v1.13.0` -> `v1.14.0` |

---

###  Dependency Lookup Warnings 

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>spf13/viper</summary>

### [`v1.14.0`](https://togithub.com/spf13/viper/releases/tag/v1.14.0)

[Compare
Source](https://togithub.com/spf13/viper/compare/v1.13.0...v1.14.0)

<!-- Release notes generated using configuration in .github/release.yml
at v1.14.0 -->

#### What's Changed

##### Enhancements 🚀

- feat: make Viper compile on platforms unsupported by fsnotify by
[@&#8203;sagikazarmark](https://togithub.com/sagikazarmark) in
[spf13/viper#1457
- Fsnotify improvements by
[@&#8203;sagikazarmark](https://togithub.com/sagikazarmark) in
[spf13/viper#1458
- Disable watch on appengine by
[@&#8203;sagikazarmark](https://togithub.com/sagikazarmark) in
[spf13/viper#1460

##### Breaking Changes 🛠

- Drop support for Go 1.15 by
[@&#8203;sagikazarmark](https://togithub.com/sagikazarmark) in
[spf13/viper#1428

##### Dependency Updates ⬆️

- build(deps): bump github.com/spf13/afero from 1.8.2 to 1.9.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1406
- build(deps): bump github.com/sagikazarmark/crypt from 0.6.0 to 0.7.0
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1437
- build(deps): bump github.com/stretchr/testify from 1.8.0 to 1.8.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1453
- build(deps): bump github.com/fsnotify/fsnotify from 1.5.4 to 1.6.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1449
- chore: update crypt by
[@&#8203;sagikazarmark](https://togithub.com/sagikazarmark) in
[spf13/viper#1461

**Full Changelog**:
spf13/viper@v1.13.0...v1.14.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzQuMTkuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
estahn pushed a commit to estahn/k8s-image-swapper that referenced this pull request Dec 1, 2022
## [1.3.3](v1.3.2...v1.3.3) (2022-12-01)

### ⬆️ Dependencies

* **deps:** Bump alpine from 3.16.2 to 3.16.3 ([#388](#388)) ([ffae497](ffae497))
* **deps:** Bump alpine from 3.16.3 to 3.17.0 ([#395](#395)) ([d32255d](d32255d))
* **deps:** Bump github.com/aws/aws-sdk-go from 1.44.126 to 1.44.136 ([#391](#391)) ([61a6ae2](61a6ae2)), closes [#4620](https://github.com/estahn/k8s-image-swapper/issues/4620) [#4619](https://github.com/estahn/k8s-image-swapper/issues/4619) [#4617](https://github.com/estahn/k8s-image-swapper/issues/4617) [#4616](https://github.com/estahn/k8s-image-swapper/issues/4616) [#4615](https://github.com/estahn/k8s-image-swapper/issues/4615) [#4614](https://github.com/estahn/k8s-image-swapper/issues/4614) [#4613](https://github.com/estahn/k8s-image-swapper/issues/4613) [#4611](https://github.com/estahn/k8s-image-swapper/issues/4611) [#4608](https://github.com/estahn/k8s-image-swapper/issues/4608) [#4609](https://github.com/estahn/k8s-image-swapper/issues/4609)
* **deps:** Bump github.com/aws/aws-sdk-go from 1.44.136 to 1.44.146 ([#397](#397)) ([d4a6136](d4a6136)), closes [#4638](https://github.com/estahn/k8s-image-swapper/issues/4638) [#4636](https://github.com/estahn/k8s-image-swapper/issues/4636) [#4633](https://github.com/estahn/k8s-image-swapper/issues/4633) [#4632](https://github.com/estahn/k8s-image-swapper/issues/4632) [#4630](https://github.com/estahn/k8s-image-swapper/issues/4630) [#4628](https://github.com/estahn/k8s-image-swapper/issues/4628) [#4627](https://github.com/estahn/k8s-image-swapper/issues/4627) [#4626](https://github.com/estahn/k8s-image-swapper/issues/4626) [#4625](https://github.com/estahn/k8s-image-swapper/issues/4625) [#4624](https://github.com/estahn/k8s-image-swapper/issues/4624)
* **deps:** Bump github.com/containers/image/v5 from 5.23.0 to 5.23.1 ([#393](#393)) ([84f4d18](84f4d18))
* **deps:** Bump github.com/go-co-op/gocron from 1.17.1 to 1.18.0 ([#390](#390)) ([1750ee9](1750ee9)), closes [go-co-op/gocron#388](go-co-op/gocron#388) [go-co-op/gocron#389](go-co-op/gocron#389) [go-co-op/gocron#392](go-co-op/gocron#392) [go-co-op/gocron#394](go-co-op/gocron#394) [go-co-op/gocron#393](go-co-op/gocron#393) [go-co-op/gocron#392](go-co-op/gocron#392) [go-co-op/gocron#394](go-co-op/gocron#394) [#393](#393) [#394](#394) [#392](#392) [#389](#389)
* **deps:** Bump github.com/gruntwork-io/terratest from 0.40.24 to 0.41.3 ([#398](#398)) ([ab35b1a](ab35b1a)), closes [gruntwork-io/terratest#1203](gruntwork-io/terratest#1203) [gruntwork-io/terratest#1202](gruntwork-io/terratest#1202) [gruntwork-io/terratest#1201](gruntwork-io/terratest#1201) [gruntwork-io/terratest#1199](gruntwork-io/terratest#1199) [gruntwork-io/terratest#1196](gruntwork-io/terratest#1196) [#1202](https://github.com/estahn/k8s-image-swapper/issues/1202) [#1203](https://github.com/estahn/k8s-image-swapper/issues/1203) [#1201](https://github.com/estahn/k8s-image-swapper/issues/1201) [#1199](https://github.com/estahn/k8s-image-swapper/issues/1199) [#1196](https://github.com/estahn/k8s-image-swapper/issues/1196)
* **deps:** Bump github.com/prometheus/client_golang from 1.13.0 to 1.13.1 ([#387](#387)) ([b155a16](b155a16)), closes [#1146](https://github.com/estahn/k8s-image-swapper/issues/1146) [#1148](https://github.com/estahn/k8s-image-swapper/issues/1148) [#1118](https://github.com/estahn/k8s-image-swapper/issues/1118) [#1146](https://github.com/estahn/k8s-image-swapper/issues/1146) [#1148](https://github.com/estahn/k8s-image-swapper/issues/1148) [#1118](https://github.com/estahn/k8s-image-swapper/issues/1118) [#1157](https://github.com/estahn/k8s-image-swapper/issues/1157) [#1146](https://github.com/estahn/k8s-image-swapper/issues/1146) [#1148](https://github.com/estahn/k8s-image-swapper/issues/1148) [#1118](https://github.com/estahn/k8s-image-swapper/issues/1118)
* **deps:** Bump github.com/prometheus/client_golang from 1.13.1 to 1.14.0 ([#392](#392)) ([af00594](af00594)), closes [#1150](https://github.com/estahn/k8s-image-swapper/issues/1150) [#1103](https://github.com/estahn/k8s-image-swapper/issues/1103) [prometheus/client_golang#1118](prometheus/client_golang#1118) [prometheus/client_golang#1103](prometheus/client_golang#1103) [prometheus/client_golang#1125](prometheus/client_golang#1125) [prometheus/client_golang#1130](prometheus/client_golang#1130) [prometheus/client_golang#1148](prometheus/client_golang#1148) [prometheus/client_golang#1146](prometheus/client_golang#1146) [prometheus/client_golang#1152](prometheus/client_golang#1152) [#1150](https://github.com/estahn/k8s-image-swapper/issues/1150) [#1103](https://github.com/estahn/k8s-image-swapper/issues/1103) [#1162](https://github.com/estahn/k8s-image-swapper/issues/1162) [#1161](https://github.com/estahn/k8s-image-swapper/issues/1161) [#1160](https://github.com/estahn/k8s-image-swapper/issues/1160) [#1136](https://github.com/estahn/k8s-image-swapper/issues/1136) [#1133](https://github.com/estahn/k8s-image-swapper/issues/1133) [#1150](https://github.com/estahn/k8s-image-swapper/issues/1150) [#1152](https://github.com/estahn/k8s-image-swapper/issues/1152)
* **deps:** Bump github.com/spf13/viper from 1.13.0 to 1.14.0 ([#385](#385)) ([6f79498](6f79498)), closes [spf13/viper#1457](spf13/viper#1457) [spf13/viper#1458](spf13/viper#1458) [spf13/viper#1460](spf13/viper#1460) [spf13/viper#1428](spf13/viper#1428) [spf13/viper#1406](spf13/viper#1406) [spf13/viper#1437](spf13/viper#1437) [spf13/viper#1453](spf13/viper#1453) [spf13/viper#1449](spf13/viper#1449) [spf13/viper#1461](spf13/viper#1461)
* **deps:** Bump golangci/golangci-lint-action from 3.3.0 to 3.3.1 ([#389](#389)) ([0b50f7b](0b50f7b)), closes [golangci/golangci-lint-action#590](golangci/golangci-lint-action#590) [golangci/golangci-lint-action#591](golangci/golangci-lint-action#591) [golangci/golangci-lint-action#592](golangci/golangci-lint-action#592) [golangci/golangci-lint-action#593](golangci/golangci-lint-action#593) [golangci/golangci-lint-action#594](golangci/golangci-lint-action#594) [golangci/golangci-lint-action#595](golangci/golangci-lint-action#595) [golangci/golangci-lint-action#596](golangci/golangci-lint-action#596) [golangci/golangci-lint-action#597](golangci/golangci-lint-action#597) [golangci/golangci-lint-action#598](golangci/golangci-lint-action#598) [golangci/golangci-lint-action#599](golangci/golangci-lint-action#599) [#599](https://github.com/estahn/k8s-image-swapper/issues/599) [#598](https://github.com/estahn/k8s-image-swapper/issues/598) [#596](https://github.com/estahn/k8s-image-swapper/issues/596) [#595](https://github.com/estahn/k8s-image-swapper/issues/595) [#593](https://github.com/estahn/k8s-image-swapper/issues/593) [#591](https://github.com/estahn/k8s-image-swapper/issues/591) [#590](https://github.com/estahn/k8s-image-swapper/issues/590)
* **deps:** Bump hmarr/auto-approve-action from 2 to 3 ([#396](#396)) ([0b982a2](0b982a2)), closes [hmarr/auto-approve-action#205](hmarr/auto-approve-action#205) [hmarr/auto-approve-action#202](hmarr/auto-approve-action#202) [hmarr/auto-approve-action#202](hmarr/auto-approve-action#202) [hmarr/auto-approve-action#200](hmarr/auto-approve-action#200) [hmarr/auto-approve-action#200](hmarr/auto-approve-action#200) [hmarr/auto-approve-action#186](hmarr/auto-approve-action#186) [hmarr/auto-approve-action#191](hmarr/auto-approve-action#191) [#210](#210) [#205](#205)
* **deps:** Bump k8s.io/api from 0.25.3 to 0.25.4 ([#401](#401)) ([0f80b5d](0f80b5d))
* **deps:** Bump k8s.io/apimachinery from 0.25.3 to 0.25.4 ([#399](#399)) ([1f0944f](1f0944f)), closes [#112218](https://github.com/estahn/k8s-image-swapper/issues/112218) [haoruan/automated-cherry-pick-of-#111936](https://github.com/haoruan/automated-cherry-pick-of-/issues/111936)
* **deps:** Bump k8s.io/client-go from 0.25.3 to 0.25.4 ([#400](#400)) ([ad036e0](ad036e0))
kurtisvg pushed a commit to googleapis/btlr that referenced this pull request Jan 5, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/spf13/viper](https://togithub.com/spf13/viper) | require |
minor | `v1.12.0` -> `v1.14.0` |

---

### Release Notes

<details>
<summary>spf13/viper</summary>

### [`v1.14.0`](https://togithub.com/spf13/viper/releases/tag/v1.14.0)

[Compare
Source](https://togithub.com/spf13/viper/compare/v1.13.0...v1.14.0)

<!-- Release notes generated using configuration in .github/release.yml
at v1.14.0 -->

##### What's Changed

##### Enhancements 🚀

- feat: make Viper compile on platforms unsupported by fsnotify by
[@&#8203;sagikazarmark](https://togithub.com/sagikazarmark) in
[spf13/viper#1457
- Fsnotify improvements by
[@&#8203;sagikazarmark](https://togithub.com/sagikazarmark) in
[spf13/viper#1458
- Disable watch on appengine by
[@&#8203;sagikazarmark](https://togithub.com/sagikazarmark) in
[spf13/viper#1460

##### Breaking Changes 🛠

- Drop support for Go 1.15 by
[@&#8203;sagikazarmark](https://togithub.com/sagikazarmark) in
[spf13/viper#1428

##### Dependency Updates ⬆️

- build(deps): bump github.com/spf13/afero from 1.8.2 to 1.9.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1406
- build(deps): bump github.com/sagikazarmark/crypt from 0.6.0 to 0.7.0
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1437
- build(deps): bump github.com/stretchr/testify from 1.8.0 to 1.8.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1453
- build(deps): bump github.com/fsnotify/fsnotify from 1.5.4 to 1.6.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1449
- chore: update crypt by
[@&#8203;sagikazarmark](https://togithub.com/sagikazarmark) in
[spf13/viper#1461

**Full Changelog**:
spf13/viper@v1.13.0...v1.14.0

### [`v1.13.0`](https://togithub.com/spf13/viper/releases/tag/v1.13.0)

[Compare
Source](https://togithub.com/spf13/viper/compare/v1.12.0...v1.13.0)

**Important:** This is the last release supporting Go 1.15.

#### What's Changed

##### Exciting New Features 🎉

- Add etcd3 to supported remote providers by
[@&#8203;franklinkim](https://togithub.com/franklinkim) in
[spf13/viper#1371

##### Enhancements 🚀

- Fix go-staticcheck failures (ST1005) by
[@&#8203;mjmaisey](https://togithub.com/mjmaisey) in
[spf13/viper#1373
- Use jsonc in markdown codeblocks for better readability by
[@&#8203;HurSungYun](https://togithub.com/HurSungYun) in
[spf13/viper#1393
- Add Go 1.19 support by
[@&#8203;sagikazarmark](https://togithub.com/sagikazarmark) in
[spf13/viper#1424
- Adds support for uint16 with `GetUint16` by
[@&#8203;oxisto](https://togithub.com/oxisto) in
[spf13/viper#1405
- Add a DebugTo convenience funtion by
[@&#8203;bcrochet](https://togithub.com/bcrochet) in
[spf13/viper#1414

##### Bug Fixes 🐛

- Recurse into arrays when converting keys to lowercase by
[@&#8203;awrichar](https://togithub.com/awrichar) in
[spf13/viper#1387

##### Dependency Updates ⬆️

- build(deps): bump github.com/stretchr/testify from 1.7.1 to 1.7.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1374
- build(deps): bump github.com/subosito/gotenv from 1.3.0 to 1.4.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1375
- build(deps): bump github.com/pelletier/go-toml/v2 from 2.0.1 to 2.0.2
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1378
- build(deps): bump gopkg.in/yaml.v3 from 3.0.0 to 3.0.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1360
- build(deps): bump github.com/stretchr/testify from 1.7.2 to 1.7.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1381
- build(deps): bump github.com/stretchr/testify from 1.7.3 to 1.7.4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1384
- build(deps): bump mheap/github-action-required-labels from 1 to 2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1383
- build(deps): bump github.com/stretchr/testify from 1.7.4 to 1.8.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1395
- build(deps): bump github.com/subosito/gotenv from 1.4.0 to 1.4.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1420
- build(deps): bump github.com/pelletier/go-toml/v2 from 2.0.2 to 2.0.5
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1422
- build(deps): bump gopkg.in/ini.v1 from 1.66.4 to 1.67.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[spf13/viper#1412

#### New Contributors

- [@&#8203;mjmaisey](https://togithub.com/mjmaisey) made their first
contribution in
[spf13/viper#1373
- [@&#8203;HurSungYun](https://togithub.com/HurSungYun) made their first
contribution in
[spf13/viper#1393
- [@&#8203;franklinkim](https://togithub.com/franklinkim) made their
first contribution in
[spf13/viper#1371
- [@&#8203;awrichar](https://togithub.com/awrichar) made their first
contribution in
[spf13/viper#1387
- [@&#8203;oxisto](https://togithub.com/oxisto) made their first
contribution in
[spf13/viper#1405
- [@&#8203;bcrochet](https://togithub.com/bcrochet) made their first
contribution in
[spf13/viper#1414

**Full Changelog**:
spf13/viper@v1.12.0...v1.13.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

 **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/googleapis/btlr).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTIuMiIsInVwZGF0ZWRJblZlciI6IjM0LjI4LjAifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

just a little code style question Code confusion in function WatchConfig()
1 participant