fix(inventory.coffee): fix error in restockable in days #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LEQADA
reviewed
Dec 28, 2018
| actions = [] | ||
| if diff.restockableInDays | ||
| if _.isArray(diff.restockableInDays) | ||
| size = _.size(diff.restockableInDays) | ||
| console.log size |
There was a problem hiding this comment.
It probably was a testing print? 🙂
hajoeichler
suggested changes
Dec 29, 2018
| @@ -49,23 +49,23 @@ class InventoryUtils extends BaseUtils | |||
| # diff - {Object} The result of diff from `jsondiffpatch` | |||
| # | |||
| # Returns {Array} The list of actions, or empty if there are none | |||
| actionsMapRestockableInDays: (diff) -> | |||
| actionsMapRestockableInDays: (diff, old_obj) -> | |||
There was a problem hiding this comment.
Why do you get the old_obj here, but you don't use it.
| if size is 1 | ||
| a.restockableInDays = diff.restockableInDays[0] | ||
| else if size is 2 | ||
| if size is 2 |
There was a problem hiding this comment.
If you don't change the order of the if/else statement, the actual change is one line.
hajoeichler
approved these changes
Dec 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix update error in RestockableInDays
Description
No update is shown when new RestockableInDays value is passed.
Todo
closes #276