Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(product): add option to match by only one attr (#327) #328

Merged
merged 1 commit into from
Mar 23, 2020
Merged

feat(product): add option to match by only one attr (#327) #328

merged 1 commit into from
Mar 23, 2020

Conversation

lojzatran
Copy link
Contributor

Summary

Fixes #327

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 97.73% when pulling 9d6588f on 327-match-variant-by-attr into 8af7290 on master.

daern91
daern91 approved these changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@daern91 daern91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@daern91 daern91 merged commit 0c2da42 into master Mar 23, 2020
@daern91 daern91 deleted the 327-match-variant-by-attr branch March 23, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daern91 daern91 daern91 approved these changes

@ahmetoz ahmetoz ahmetoz approved these changes

@butenkor butenkor Awaiting requested review from butenkor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to find matching variant by only one attribute
4 participants
@lojzatran @coveralls @ahmetoz @daern91