Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(product-sync): findVariantInList when attributeToMatchBy used. #329

Merged
merged 1 commit into from
Mar 24, 2020
Merged

fix(product-sync): findVariantInList when attributeToMatchBy used. #329

merged 1 commit into from
Mar 24, 2020

Conversation

ahmetoz
Copy link
Contributor

@ahmetoz ahmetoz commented Mar 24, 2020

Summary

Description

Todo

  • Tests
    • Unit
    • Integration
    • Acceptance
  • Documentation

@ahmetoz ahmetoz requested a review from lojzatran March 24, 2020 11:41
@ahmetoz ahmetoz changed the title fix(product-sync): findVariantInList error when attributeToMatchBy used. fix(product-sync): findVariantInList when attributeToMatchBy used. Mar 24, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.733% when pulling c88cdd8 on fix-matchByAttr-usage into f0381e3 on master.

@ahmetoz ahmetoz merged commit c664974 into master Mar 24, 2020
@ahmetoz ahmetoz deleted the fix-matchByAttr-usage branch March 24, 2020 11:56
@ahmetoz ahmetoz removed the request for review from lojzatran March 24, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmetoz @coveralls