Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External Link Footnotes Not Working in Definition List #1237

Closed
shimizukawa opened this issue Jan 3, 2015 · 1 comment
Closed

External Link Footnotes Not Working in Definition List #1237

shimizukawa opened this issue Jan 3, 2015 · 1 comment
Assignees
@tk0miya
Labels
builder:latex type:bug
Milestone
1.3.4

Comments

@shimizukawa
Copy link
Member

When a definition list term is an external link, and the "latex_show_urls" option is set to "footnote", the generated PDF shows the footnote number next to the link, but fails to create a footnote at the bottom of the page.

The generated LaTeX looks like this:

#!latex

\item[{\href{http://sphinx-doc.org}{Sphinx Website}\footnote{http://sphinx-doc.org}}] \leavevmode

If you change it to look like the following, then the footnote shows up a the bottom, but the number is a space away from the link:

#!latex

\item[{\href{http://sphinx-doc.org}{Sphinx Website}}]\footnote{http://sphinx-doc.org} \leavevmode

I'm not fluent in LaTeX, so there might be a better solution that keeps the number next to the link while producing the footnote.
@shimizukawa shimizukawa added this to the 1.2 milestone Jan 3, 2015
@birkenfeld birkenfeld modified the milestones: 1.2, 1.2.x Jan 17, 2015
@shimizukawa shimizukawa modified the milestones: 1.3.3, 1.2.x Jul 10, 2015
@shimizukawa shimizukawa modified the milestones: 1.3.3, 1.3.4 Dec 2, 2015
tk0miya added a commit that referenced this issue Dec 8, 2015
@tk0miya
Fix #1237 footnotes not working in definition list in LaTeX
09140ca
@tk0miya tk0miya mentioned this issue Dec 8, 2015
Merged
@tk0miya tk0miya self-assigned this Dec 8, 2015
tk0miya added a commit that referenced this issue Dec 19, 2015
@tk0miya
Fix #1237 footnotes not working in definition list in LaTeX
5983d02
tk0miya added a commit that referenced this issue Dec 19, 2015
@tk0miya
Merge pull request #2159 from sphinx-doc/1237_footnote_in_deflist
157375b 
Fix #1237 footnotes not working in definition list in LaTeX
@tk0miya
Copy link
Member

tk0miya commented Dec 19, 2015

Fixed at #2159.

@tk0miya tk0miya closed this as completed Dec 19, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tk0miya tk0miya

Labels
builder:latex type:bug
Projects
None yet
Milestone
1.3.4
Development

No branches or pull requests
3 participants
@birkenfeld @shimizukawa @tk0miya