Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link checker doesn't accept gzip content #2775

Closed
nijel opened this issue Jul 13, 2016 · 5 comments
Closed

Link checker doesn't accept gzip content #2775

nijel opened this issue Jul 13, 2016 · 5 comments
Labels

Comments

@nijel
Copy link
Contributor

nijel commented Jul 13, 2016

When server is configured to server only compressed content, linkcheck fails. For example this can be seen on https://tcpdf.org/.

This can be simply fixed by adding Accept-encoding: gzip header to the URL opener (at least for HEAD requests, for GET and anchor checking probably more work would be needed).

I can see that master branch has switched to using requests, where this case works just fine. I just would like to see this work in released version as well...

@tk0miya
Copy link
Member

tk0miya commented Jul 15, 2016

Are you saying master branch works fine? If true, please wait a next major release. because it seems too hard and meaningless to support it on stable branch.

Until the release, you can download it from https://github.com/sphinx-doc/sphinx/archive/master.zip

Note: master branch is still in develop, so there might be some bugs.

@nijel
Copy link
Contributor Author

nijel commented Jul 17, 2016

Yes, it seems to work fine in master. I just have no clue what is
schedule for releasing it and so whether it's worth fixing in stable
releases before...

Dne 15.7.2016 v 04:55 Takeshi KOMIYA napsal(a):

Are you saying master branch works fine? If true, please wait a next
major release. because it seems too hard and meaningless to support it
on stable branch.

Until the release, you can download it from
https://github.com/sphinx-doc/sphinx/archive/master.zip

Note: master branch is still in develop, so there might be some bugs.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2775 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAM83a7SYexyGNjjnDmvJ7dCLGIKwpcWks5qVvatgaJpZM4JLHN3.

@tk0miya
Copy link
Member

tk0miya commented Jul 18, 2016

The target day for next major release is not planed yet. But, IMO, it might be released in this autumn.

Of course, all contributions are welcome. so it's okay to merge PR to fix this on stable branch.

@nijel
Copy link
Contributor Author

nijel commented Jul 24, 2016

Here comes the PR: #2809

@tk0miya
Copy link
Member

tk0miya commented Jul 27, 2016

Merged #2809.

@tk0miya tk0miya closed this as completed Jul 27, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants