Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ User Defined Literals not supported #7294

Closed
mpusz opened this issue Mar 11, 2020 · 1 comment · Fixed by #7590
Closed

C++ User Defined Literals not supported #7294

mpusz opened this issue Mar 11, 2020 · 1 comment · Fixed by #7590
Labels
domains:cpp type:enhancement enhance or introduce a new feature

Comments

@mpusz
Copy link

mpusz commented Mar 11, 2020

The code as below

namespace units::si {

inline constexpr auto planck_constant = 6.62607015e-34q_J * 1q_s;

}

causes the following error:

WARNING: Invalid definition: Expected end of definition. [error at 58]
[build]   constexpr auto units::si::planck_constant = 6.62607015e-34q_J * 1q_s
[build]   ----------------------------------------------------------^

According to https://github.com/sphinx-doc/sphinx/blob/3.x/sphinx/domains/cpp.py#L4770 Sphinx seems to not have features for UDLs. Could you please add those?
@mpusz mpusz added the type:bug label Mar 11, 2020
@mpusz mpusz mentioned this issue Mar 11, 2020
Closed
@tk0miya tk0miya added domains:cpp type:enhancement enhance or introduce a new feature and removed type:bug labels Mar 11, 2020
jakobandersen added a commit to jakobandersen/sphinx that referenced this issue May 1, 2020
@jakobandersen
C++, parse expressions with user-defined literals
f2b40bc 
Fixes sphinx-doc#7294
@jakobandersen jakobandersen mentioned this issue May 1, 2020
Merged
jakobandersen added a commit to jakobandersen/sphinx that referenced this issue May 1, 2020
@jakobandersen
C++, parse expressions with user-defined literals
bfc3200 
Fixes sphinx-doc#7294
@jakobandersen
Copy link
Contributor

Fixed in the 3.x branch (future v3.1).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
domains:cpp type:enhancement enhance or introduce a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

C++, parse expressions with user-defined literals jakobandersen/sphinx
3 participants
@mpusz @tk0miya @jakobandersen