-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImgConverter runs is_available in HTML builder #7973
Comments
Why do you think so? It is available for all of the builders. For example, it converts PDF image to an appropriate format for |
I use the svg2pdf-converter extension which is based on the ImageConverter class. Currently on windows it throws 150+ errors (one per document) because of missing dependencies. Since we only build PDF on latex we were hoping using the extension wouldn't be a problem. |
I understand. I agreed that so many warnings are meaningless and noisy. It would be better to emit only one warning during the build (Note: I don't think to suppress all of the warnings is better). |
…many times To prevent checking the availability of image converters times and times again, this stores the result to the class variable. It is not a good design to have a state globally. So this should be refactored in the future.
…many times To prevent checking the availability of image converters times and times again, this stores the result to the class variable. It is not a good design to have a state globally. So this should be refactored in the future.
Fix #7973: imgconverter: Check availability of imagemagick many times
Close sphinx-doc#7973: ImgConverter runs is_available in HTML builder Close missinglinkelectronics/sphinxcontrib-svg2pdfconverter#8: Extension should only run on LaTeX builder
Since ImgConverter is only used in the LaTeX builder, this check should not happen in HTML.
The text was updated successfully, but these errors were encountered: