Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial update for russian translation #12392

Closed

Conversation

dunmaksim
Copy link

Subject: partial update for russian translation

@@ -3732,7 +3739,7 @@ msgstr ""
#: sphinx/writers/latex.py:1388
#, python-format
msgid "dimension unit %s is invalid. Ignored."
msgstr ""
msgstr "неправильная единица измерения. Пропускается."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a %s is missing there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Fixed.

@dunmaksim dunmaksim requested a review from n-peugnet May 27, 2024 19:53
Copy link
Contributor

@n-peugnet n-peugnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some time to check on my computer and gettext discovered some more errors (sorry I should have started with this), could you please correct them?

$ msgfmt --check -o ru/LC_MESSAGES/sphinx.mo ru/LC_MESSAGES/sphinx.po
ru/LC_MESSAGES/sphinx.po:226: 'msgid' and 'msgstr' entries do not both end with '\n'
ru/LC_MESSAGES/sphinx.po:951: 'msgstr' is not a valid Python format string, unlike 'msgid'. Reason: The string ends in the middle of a directive.
ru/LC_MESSAGES/sphinx.po:956: 'msgstr' is not a valid Python format string, unlike 'msgid'. Reason: The string ends in the middle of a directive.
ru/LC_MESSAGES/sphinx.po:966: 'msgstr' is not a valid Python format string, unlike 'msgid'. Reason: The string ends in the middle of a directive.
ru/LC_MESSAGES/sphinx.po:1135: 'msgstr' is not a valid Python format string, unlike 'msgid'. Reason: The string ends in the middle of a directive.
ru/LC_MESSAGES/sphinx.po:3393: 'msgstr' is not a valid Python format string, unlike 'msgid'. Reason: The string ends in the middle of a directive.
msgfmt: found 6 fatal errors

I added some hints in comments below.

You might also want to update the Last-Translator field of the header.

sphinx/locale/ru/LC_MESSAGES/sphinx.po Outdated Show resolved Hide resolved
sphinx/locale/ru/LC_MESSAGES/sphinx.po Outdated Show resolved Hide resolved
@dunmaksim
Copy link
Author

Hello!
Me rebased branch for running checks. What I must do next?

@chrisjsewell
Copy link
Member

chrisjsewell commented Jun 3, 2024

Hello! Me rebased branch for running checks. What I must do next?

Heya, I believe we just want to get in #12392 first

Copy link
Contributor

@n-peugnet n-peugnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I just noticed that there is a list of translators in the topmost comment of the file, you might also want to add yourself there @dunmaksim.

@dunmaksim
Copy link
Author

Looks good to me.

I just noticed that there is a list of translators in the topmost comment of the file, you might also want to add yourself there @dunmaksim.

Maybe later.

@rffontenelle
Copy link
Contributor

Meeging this won't be replaced by the Russian translations from a Transifex or create a async between what is translated in here and in there?

@n-peugnet
Copy link
Contributor

Meeging this won't be replaced by the Russian translations from a Transifex or create a async between what is translated in here and in there?

I assumed that Transifex worked somewhat similarly to Weblate and always used to files from the git repo as the source, but it is not the case. Currently the only file pushed to Transifex is the source (the sphinx.pot template) and not the *.po files:

/tmp/tx_cli/tx push --source --use-git-timestamps --workers 10

But we could also push the translation files using the -t/--translation flag as explained in transifex-cli docs:

By default, the client will push the source file (the file that's being pointed to by the source_file configuration option from tx add). If you use the -t/--translation flag, tx push will push translation files. This may be desirable if, for example, you previously pulled translation files with the --mode translator option, translated using an offline translation tool and now you want to push your work to Transifex, or if you are migrating from
another localization management service to Transifex. If you use both the -t and the -s/--source flags, then you will push both the source file and the translation files.

@rffontenelle
Copy link
Contributor

Indeed. If merging, I'd recommend immediately pushing it to Transifex to not lose it in the next transifex.yml workflow run after a Russian transltion update in the Transifex.

For what is worth, any translator member of the translation team can upload the PO file with changes to the Sphinx resource in Transifex.

@dunmaksim
Copy link
Author

Hello! I joined to Transifex project Sphinx and make changes in russian translation here.

@dunmaksim dunmaksim closed this Jun 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants