-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial update for russian translation #12392
Conversation
@@ -3732,7 +3739,7 @@ msgstr "" | |||
#: sphinx/writers/latex.py:1388 | |||
#, python-format | |||
msgid "dimension unit %s is invalid. Ignored." | |||
msgstr "" | |||
msgstr "неправильная единица измерения. Пропускается." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a %s
is missing there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some time to check on my computer and gettext discovered some more errors (sorry I should have started with this), could you please correct them?
$ msgfmt --check -o ru/LC_MESSAGES/sphinx.mo ru/LC_MESSAGES/sphinx.po
ru/LC_MESSAGES/sphinx.po:226: 'msgid' and 'msgstr' entries do not both end with '\n'
ru/LC_MESSAGES/sphinx.po:951: 'msgstr' is not a valid Python format string, unlike 'msgid'. Reason: The string ends in the middle of a directive.
ru/LC_MESSAGES/sphinx.po:956: 'msgstr' is not a valid Python format string, unlike 'msgid'. Reason: The string ends in the middle of a directive.
ru/LC_MESSAGES/sphinx.po:966: 'msgstr' is not a valid Python format string, unlike 'msgid'. Reason: The string ends in the middle of a directive.
ru/LC_MESSAGES/sphinx.po:1135: 'msgstr' is not a valid Python format string, unlike 'msgid'. Reason: The string ends in the middle of a directive.
ru/LC_MESSAGES/sphinx.po:3393: 'msgstr' is not a valid Python format string, unlike 'msgid'. Reason: The string ends in the middle of a directive.
msgfmt: found 6 fatal errors
I added some hints in comments below.
You might also want to update the Last-Translator
field of the header.
f8127a3
to
3ddc101
Compare
3ddc101
to
d47ef6d
Compare
Hello! |
Heya, I believe we just want to get in #12392 first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I just noticed that there is a list of translators in the topmost comment of the file, you might also want to add yourself there @dunmaksim.
Maybe later. |
Meeging this won't be replaced by the Russian translations from a Transifex or create a async between what is translated in here and in there? |
I assumed that Transifex worked somewhat similarly to Weblate and always used to files from the git repo as the source, but it is not the case. Currently the only file pushed to Transifex is the source (the sphinx.pot template) and not the *.po files: sphinx/.github/workflows/transifex.yml Line 35 in 568e26c
But we could also push the translation files using the
|
Indeed. If merging, I'd recommend immediately pushing it to Transifex to not lose it in the next transifex.yml workflow run after a Russian transltion update in the Transifex. For what is worth, any translator member of the translation team can upload the PO file with changes to the Sphinx resource in Transifex. |
Hello! I joined to Transifex project Sphinx and make changes in russian translation here. |
Subject: partial update for russian translation