-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locale check script + CI job, that runs gettext check #12394
Conversation
Heya thanks, My main question though, that I've asked previously (https://github.com/orgs/sphinx-doc/discussions/12249#discussioncomment-9062264) is what is the workflow for submitting translations? At present it seems that it is NOT directly through this repository; it "should" be done at https://explore.transifex.com/sphinx-doc/ If this is the case, then essentially this PR is not needed, and we should "reject" all PRs like #12392, and show them how to do it on transifex I feel, at a minimum, we at least need to document this better |
It feels a little bit sad to force the translations to be created via Transifex for at least 2 reasons:
As I see it, Transifex can be a great addition to help new translators contribute (though for this purpose I find Weblate more interesting, as it allows to see what the tool looks like even before registering an account). But IMO it should not be a requirement to contribute to translations. Having said that, maybe the current translation workflow is more hierarchical than I thought and needs a review by translation maintainers, but I can't see it because I didn't register an account on Transifex. So I agree with your last point:
|
26a21d6
to
6dd29a7
Compare
@rffontenelle maybe you wanted to quickly check this also, since you are doing the work on https://github.com/sphinx-doc/sphinx-doc-translations |
Since currently the .po files directly modified in this repo are not pushed back to transifex (see #12392 (comment)), it does not make sense to add this check here. But instead, maybe a |
Subject: Add script + CI job to check locale files with gettext
Feature or Bugfix
Purpose
Relates
P.S. The docs build will be fixed by #12395