Making snazzier inheritance diagrams #1697
Conversation
Three major overhauls: * explicit directive arguments will be displayed irrespective of the :private-bases: option. This includes builtin classes. * Graph nodes can be omitted. For example, given the following inheritance chain Exception->TypeError->CustomError and the arguments Exception and CustomError, the resulting graph will not display TypeError, and the Exception and CustomError nodes will be directly linked * Nodes of builtin classes have a new style derived from the default style. There is also an accompanying option inheritance_node_attrs_builtin. As a result, the "style" member of the configuration dictionaries is now an iterable. Todo (maybe): * tidy the Graph class * provide a new edge style for omitted connections
|
Thanks for the PR! I'll check out the new snazziness when I got a bit of time. |
By sorting the graph over name-keys.
|
FTR, the build failure is just a pip-download timeout, unrelated to the actual commit. |
|
Is there anything that needs to be done before merging ? |
|
Reviewing right now... |
| cache.add(node) | ||
| yield (name, node) | ||
| for name in selector(node): | ||
| yield from node_iterate(name, selector) |
There was a problem hiding this comment.
Unfortunately, "yield from" is not compatible with Python 2.6 and 2.7.
Hmm, this doesn't appear to be the case for me. |
| @property | ||
| def names_data(self): | ||
| return\ | ||
| { name:node |
There was a problem hiding this comment.
Dict comprehensions are not available in Python 2.6.
|
I'm not trying to be picky but could you try to adhere to the general coding style of Sphinx? While it's not explicitly mentioned anywhere it should mostly be PEP 8. (@birkenfeld, correct me if I'm wrong here.) Especially, parts like this are very unlike all other code we have in Sphinx: This would normally expressed just as (assuming you need a line break in there for line length reasons): |
|
@orbisvicis @birkenfeld any progress? I'll close this inactive PR at end of Feb 2016. |
| names = self.roots | ||
| cache = set() | ||
| selector = lambda v: v.names_out | ||
| for name_root in names: |
There was a problem hiding this comment.
|
@orbisvicis @birkenfeld any progress? It's time to close pull request. |
|
Now I close this issue. Thanks, |
Three major overhauls:
the :private-bases: option. This includes builtin classes.
inheritance chain Exception->TypeError->CustomError and the arguments
Exception and CustomError, the resulting graph will not display
TypeError, and the Exception and CustomError nodes will be directly
linked
style. There is also an accompanying option
inheritance_node_attrs_builtin. As a result, the "style" member
of the configuration dictionaries is now an iterable.
Todo (maybe):