Add sphinx.parsers.Parser class; a base class for new parsers #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Might need some documentation updates? |
|
Thank you for comment. I updated docs. |
|
|
||
| A Base class for additional parsers. | ||
|
|
||
| :copyright: Copyright 2007-2015 by the Sphinx team, see AUTHORS. |
|
+1 with nits. |
tk0miya
force-pushed
the
baseclass_for_parsers
branch
from
26b1c26
to
f89e3df
Compare
tk0miya
added a commit
that referenced
this pull request
Jan 17, 2016
Add sphinx.parsers.Parser class; a base class for new parsers
The class inherits ``docutils.parsers.Parser`` and implements ``set_application()`` in addition. It enables subclasses to read configurations, to access environments and to logging.
|
Thank you for reviewing. I merged it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.3, Sphinx supports additional parsers.
But, it accepts docutils parsers simply. So the parsers could not read any configurations and environments. I can not even call
warn()to show error messages.To improve that situation, I would like to add
sphinx.parsers.Parseras a base class for Sphinx parsers.The class inherits
docutils.parsers.Parserand implementsset_application()in addition.It enables subclasses to read configurations, to access environments and to logging.