Fix #2919: Drop py26 support #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import elementtree.ElementTree as etree | ||
| except ImportError: | ||
| import cElementTree as etree | ||
| import lxml.etree as etree | ||
|
|
||
| try: | ||
| import gzip |
There was a problem hiding this comment.
Is this fallback for gzip needed?
There was a problem hiding this comment.
https://docs.python.org/release/2.4/lib/someos.html
It seems optional package until Python 2.4. It became common standard library from 2.5. Importing gzip should be success now.
tk0miya
force-pushed
the
2919_drop_py26_support
branch
from
b605f0a
to
c147f64
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.