Add PathComparer for testing and fix 2 test failure on Windows. #5943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimizukawa
commented
Jan 13, 2019
| @@ -47,3 +48,7 @@ def _initialize_test_directory(session): | |||
|
|
|||
| def pytest_sessionstart(session): | |||
| _initialize_test_directory(session) | |||
|
|
|||
|
|
|||
| def pytest_assertrepr_compare(op, left, right): | |||
There was a problem hiding this comment.
custom reporting hook for pytest
https://docs.pytest.org/en/latest/assert.html#defining-your-own-assertion-comparison
shimizukawa
commented
Jan 13, 2019
|
|
||
|
|
||
| def pytest_assertrepr_compare(op, left, right): | ||
| comparer.pytest_assertrepr_compare(op, left, right) |
There was a problem hiding this comment.
If testing is failed, pytest runner emit this output:
_______________________________ test_compare _______________________________
> assert project.path2doc('/path/to/index.rst') == PathComparer('/path/to/index2')
E assert Comparing path:
- C:/path/to/index
+ C:/path/to/index2
? +
Codecov Report
@@ Coverage Diff @@
## master #5943 +/- ##
==========================================
- Coverage 82.9% 82.88% -0.03%
==========================================
Files 293 294 +1
Lines 39536 39576 +40
Branches 5903 5909 +6
==========================================
+ Hits 32777 32801 +24
- Misses 5396 5411 +15
- Partials 1363 1364 +1
Continue to review full report at Codecov.
|
shimizukawa
force-pushed
the
pathlib-for-path-comparing-testing
branch
from
1267595
to
ef9a5ad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose