Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #4148: quickstart: some questions are removed #6066

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Closes #4148: quickstart: some questions are removed #6066

merged 1 commit into from
Feb 16, 2019

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Feb 11, 2019

Feature or Bugfix

  • Feature

Purpose

@tk0miya tk0miya added api:cmdline type:proposal a feature suggestion labels Feb 11, 2019
@tk0miya tk0miya added this to the 2.0.0 milestone Feb 11, 2019
@codecov
Copy link

codecov bot commented Feb 11, 2019 •
edited
Loading

Codecov Report

Merging #6066 into master will not change coverage.
The diff coverage is 90%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6066   +/-   ##
=======================================
  Coverage   83.04%   83.04%           
=======================================
  Files         271      271           
  Lines       39161    39161           
  Branches     5844     5844           
=======================================
  Hits        32520    32520           
  Misses       5300     5300           
  Partials     1341     1341
Impacted Files Coverage Δ
sphinx/cmd/quickstart.py 64.81% <90%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bdac80...5365349. Read the comment docs.

shimizukawa
shimizukawa approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@shimizukawa shimizukawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tk0miya tk0miya merged commit a26e9f3 into sphinx-doc:master Feb 16, 2019
@tk0miya tk0miya deleted the 4148_renew_quickstart_question branch February 16, 2019 13:50
@tk0miya
Copy link
Member Author

tk0miya commented Feb 16, 2019

Thank you for reviewing!

@winksaville winksaville mentioned this pull request Oct 2, 2020
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shimizukawa shimizukawa shimizukawa approved these changes

Assignees
No one assigned
Labels
api:cmdline type:proposal a feature suggestion
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tk0miya @shimizukawa