-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #7324: Emit a warning if multiple files for same document found #7351
Fix #7324: Emit a warning if multiple files for same document found #7351
Conversation
files = [relpath(f, self.srcdir) for f in glob(pattern)] | ||
logger.warning(__('multiple files found for the document "%s": %r\n' | ||
'Use %r for the build.'), | ||
docname, files, self.doc2path(docname), once=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now project.discover()
is called twice. So I needed to improve logger.warning()
to suppress this warning on the second call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
files = [relpath(f, self.srcdir) for f in glob(pattern)] | ||
logger.warning(__('multiple files found for the document "%s": %r\n' | ||
'Use %r for the build.'), | ||
docname, files, self.doc2path(docname), once=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you for reviewing! |
Feature or Bugfix
Purpose