Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lyrics Plus] LRCLIB Source #3027

Closed
Overimagine1 opened this issue May 16, 2024 · 13 comments · Fixed by #3067
Closed

[Lyrics Plus] LRCLIB Source #3027

Overimagine1 opened this issue May 16, 2024 · 13 comments · Fixed by #3067

Comments

@Overimagine1
Copy link

Overimagine1 commented May 16, 2024

📝 Provide a description of the new feature

LRCLIB is a service that collects lyrics from various sources, including Musixmatch, but also allows users to submit their own synced lyrics. I assume this doesn't have as much lyrics as Musixmatch but it's nice if your other sources doesn't have what you want/is inaccurate.

➕ Additional Information

No response

@Ed3151
Copy link

Ed3151 commented May 18, 2024

lyrics-plus.zip
you can use it if you want. I added lrclib for my personnel use. karaoke wouldn't work
copy both to CustomApps\lyrics-plus and run spicetify apply

@ohitstom
Copy link
Contributor

lyrics-plus.zip you can use it if you want. I added lrclib for my personnel use. karaoke wouldn't work copy both to CustomApps\lyrics-plus and run spicetify apply

why didnt you make a PR

@Ed3151
Copy link

Ed3151 commented May 19, 2024

Hello, I am totally new to github I don't know what is PR. is there any problem uploading file here

@samuelawachie
Copy link

lyrics-plus.zip you can use it if you want. I added lrclib for my personnel use. karaoke wouldn't work copy both to CustomApps\lyrics-plus and run spicetify apply

Just got this and copied them to lyrics-plus folder, and applied. But it doesn't show up in Providers list. How do I get this to work please?

@Ed3151
Copy link

Ed3151 commented Jun 11, 2024

Just got this and copied them to lyrics-plus folder, and applied. But it doesn't show up in Providers list. How do I get this to work please?

uncheck spotify and netease if selected and select musximatch on spotify from lyrics plus config. it should work

@samuelawachie
Copy link

Just got this and copied them to lyrics-plus folder, and applied. But it doesn't show up in Providers list. How do I get this to work please?

uncheck spotify and netease if selected and select musximatch on spotify from lyrics plus config. it should work

So you mean it doesn't "appear" on the Providers list? But it still uses it when only musixmatch is selected? How would one know it's working and installed then?

@Ed3151
Copy link

Ed3151 commented Jun 12, 2024

So you mean it doesn't "appear" on the Providers list? But it still uses it when only musixmatch is selected? How would one know it's working and installed then?

yep it doesn't appear on Providers list on spotify app because I just added lrclib on musixmatch class, to make it work copy CustomApps\lyrics-plus and run spicetify apply and unselect everything except musixmatch and play any song like Mockingbird by Eminem as its lyrics doesn't contain on musixmatch api. its very simple

@rxri
Copy link
Member

rxri commented Jun 12, 2024

Use files from my pull request since lrclib is added as additional provider and not in whatever way @\Ed3151 did it

@Ed3151
Copy link

Ed3151 commented Jun 13, 2024

Use files from my pull request since lrclib is added as additional provider and not in whatever way @\Ed3151 did it

I was about to say same just noticed sorry. but add /api/search?q=.. it finds more fine way than you used some songs lrc doesn't find still it has

@rxri
Copy link
Member

rxri commented Jun 13, 2024

I'm using whatever API endpoint it provides. If it's unreliable then it's not up to me to find workarounds. Per documentation it should work just fine, but I'm aware that sometimes, even when the song is in database, it returns with 404. This is the bug with lrclib and probably should be reported

@samuelawachie
Copy link

Use files from my pull request since lrclib is added as additional provider and not in whatever way @\Ed3151 did it

I was about to say same just noticed sorry. but add /api/search?q=.. it finds more fine way than you used some songs lrc doesn't find still it has

Hi again. How could I edit the script to put this option in? Coz it doesn't seem to be getting lyrics when I know that they exist in the lrclib database, and showed up in another app I use.

@samuelawachie
Copy link

Use files from my pull request since lrclib is added as additional provider and not in whatever way @\Ed3151 did it

I was about to say same just noticed sorry. but add /api/search?q=.. it finds more fine way than you used some songs lrc doesn't find still it has

Hi again. How could I edit the script to put this option in? Coz it doesn't seem to be getting lyrics when I know that they exist in the lrclib database, and showed up in another app I use.

I tried modifying the ProviderLRCLIB.js file and replaced the "const baseURL = "https://lrclib.net/api/get";" with
"const baseURL = "https://lrclib.net/api/search?q=";"
But that doesn't solve the issue, when I reckon that it should have. How else can one do this?

@samuelawachie
Copy link

Edit: It worked!! I changed it back to riri's configuration and now it's seeing the lyrics and loading them. I wonder why it didn't do that earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants