Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font changes after applying spicetify #3070

Closed
2 tasks done
Arian8j2 opened this issue Jun 16, 2024 · 17 comments
Closed
2 tasks done

Font changes after applying spicetify #3070

Arian8j2 opened this issue Jun 16, 2024 · 17 comments
Labels
πŸ› bug Something isn't working 🐧 linux

Comments

@Arian8j2
Copy link

πŸ” Have you checked Spicetify.app page for your issue?

  • I have checked the FAQ

πŸ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

β„Ή Environment / Computer Info

- Spotify version: 1.2.37.701
- Spicetify version: 2.36.12

Arch linux (kernel 6.9.3)

πŸ“ Description

After updating spotify from 1.2.31.1205 to 1.2.37.701 and updating spicetify-cli (don't remember the previous version), when i apply spicetify my default spotify font changes, i uninstalled all configs and apps associated to spicetify and spotify and reinstalled everything but the issue still exists with clean install of both apps, see screenshots below to see the font change.

πŸ“Έ Screenshots

before spicetify apply
Screenshot_2024-06-16_1718555513

after spicetify apply
image

@Arian8j2 Arian8j2 added the πŸ› bug Something isn't working label Jun 16, 2024
@rxri
Copy link
Member

rxri commented Jun 16, 2024

Spicetify does not modify the UI by default nor the font or anything related to it

@rxri rxri closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2024
@ArtyIF
Copy link

ArtyIF commented Jul 4, 2024

I'm actually getting the exact same issue. Might be related to Spotify rolling out the new Mix font, since it started happening after it rolled out for me, maybe modding the client prevents it from loading somehow?

@rxri
Copy link
Member

rxri commented Jul 4, 2024

I'm actually getting the exact same issue. Might be related to Spotify rolling out the new Mix font, since it started happening after it rolled out for me, maybe modding the client prevents it from loading somehow?

Spicetify does not modify css, nor does it prevent loading any fonts, images etc by default.

@salihefee
Copy link

I am having the same issue

@salihefee
Copy link

I'm actually getting the exact same issue. Might be related to Spotify rolling out the new Mix font, since it started happening after it rolled out for me, maybe modding the client prevents it from loading somehow?

Spicetify does not modify css, nor does it prevent loading any fonts, images etc by default.

So is it a coincidence 3 people reported the same issue after applying spicetify? That means it has something to do with spicetify doesn't it?

@rxri
Copy link
Member

rxri commented Jul 7, 2024

I'm actually getting the exact same issue. Might be related to Spotify rolling out the new Mix font, since it started happening after it rolled out for me, maybe modding the client prevents it from loading somehow?

Spicetify does not modify css, nor does it prevent loading any fonts, images etc by default.

So is it a coincidence 3 people reported the same issue after applying spicetify? That means it has something to do with spicetify doesn't it?

It doesn't need to mean anything. You can verify my claims, that we do not modify fonts or anything by looking at the source code. The only thing we use fontStyle is to create ability to use those inside HTML without having access to their internal library. check here

@crimist
Copy link

crimist commented Aug 13, 2024

Also able to reproduce.

  • Spicetify 2.37.1
  • Spotify 1.2.42.290-1
  • Arch Linux

Fully reset with the following commands to no avail.

spicetify restore
rm -r ~/.config/spicetify
spicetify restore backup apply
yay -S spotify # reinstall spotify

Devtools reveals that some fonts fail to load which is probably the issue:

Screenshot from 2024-08-13 10-53-05

@rxri
Copy link
Member

rxri commented Aug 13, 2024

These errors are not made by spicetify. Stock Spotify has those also.

@crimist
Copy link

crimist commented Aug 13, 2024

I've confirmed this issue is due to the CircularSpVietnamese-* fonts not loading.

You can see them fail to load in the network requests tab when spicetify is enabled:

Screenshot from 2024-08-13 11-05-36

To "fix" this I extracted the fonts from Spotify and created a local file override:

Screenshot from 2024-08-13 11-08-31

With the override enabled refreshing the page allows the fonts to be successfully fetched by CEF as long as the devtools are open.

Not sure if I can distribute the fonts due to licensing but you can reprod this pretty easily by extracting the fonts and then creating the following dir structure for the override.

└── xpui.app.spotify.com
    └── fonts
        └── circularSPVietnamese
            β”œβ”€β”€ CircularSpVietnamese-Bold.woff2
            β”œβ”€β”€ CircularSpVietnamese-Regular.woff2
            └── CircularSpVietnameseTitle-Variable.woff2

@crimist
Copy link

crimist commented Aug 13, 2024

It seems that when Spicetify is enabled it loads additional "Arab" and "Hebr" variants of these fonts and fails to fetch the "Vietnamese" variant compared to stock Spotify.

Unspiced Spotify:
Screenshot from 2024-08-13 11-20-17

Spiced Spotify:
Screenshot from 2024-08-13 11-21-53
Screenshot from 2024-08-13 11-21-39

@rxri
Copy link
Member

rxri commented Aug 13, 2024

It seems that when Spicetify is enabled it loads additional "Arab" and "Hebr"

You sure it's not from the theme you're using? None of these listed fonts are loaded on my end.

@crimist
Copy link

crimist commented Aug 13, 2024

I completely removed Spicetify, Spotify, and all of their .config, .cache directories as part of my troubleshooting steps so I don't believe I should have any themeing applied.

config-xpui.ini

[Setting]
current_theme          =
inject_theme_js        = 0
inject_css             = 0
replace_colors         = 0
overwrite_assets       = 0
spotify_path           = /opt/spotify/
prefs_path             = /home/crimist/.config/spotify/prefs
color_scheme           =
spotify_launch_flags   =
check_spicetify_update = 1
always_enable_devtools = 0

[Preprocesses]
disable_sentry     = 1
disable_ui_logging = 1
remove_rtl_rule    = 1
expose_apis        = 1

[AdditionalOptions]
extensions            =
custom_apps           =
sidebar_config        = 1
home_config           = 1
experimental_features = 1

[Patch]

; DO NOT CHANGE!
[Backup]
version = 1.2.42.290.g242057a2
with    = 2.37.1

Theme etc. directories empty:

$ tree Extensions CustomApps Themes
Extensions
CustomApps
Themes

0 directories, 0 files

I can attempt to reproduce this in a fresh Arch VM later to see if it's present on an unmodified system.

@rxri
Copy link
Member

rxri commented Aug 13, 2024

I see. So the Arab and Hebr are not loaded on 1.2.43 (the version I'm using) so maybe they're loaded on 1.2.42? Like I have said, spicetify does not force load any fonts or anything (you can check it by looking into the code) so it's just weird in general

@Arian8j2
Copy link
Author

i updated spotify to 1.2.42.290-1 and the problem is gone for me.
fwiw i asked from my other friends if they had this issue the day after i opened this issue and they also was on arch but didn't had the issue, same spotify and spicetify version but they didn't had the issue, so i don't think the problem is reproducible in a fresh arch install, it's probably a problem with combination of some packages.

@tuboke
Copy link

tuboke commented Sep 14, 2024

I've been having the same issue for the past few months and it seems that the problem was indeed the Vietnamese fonts, though the client wasn't able to fetch them not because they weren't there, but because the letter casing in these fonts' file names was wrong: console output said that the client was searching for "CircularSpVietnamese-*" but all the fonts inside ~/.config/spicetify/ and /opt/spotify/ (I'm using AUR version on Arch Linux) were named "CircularSPVietnamese-*". I guess this happened because Linux file system is case sensitive, so clients on Linux won't load the files if they have wrong letter cases.
I renamed all the problematic files manually (no idea if renaming them all was needed, did so just to be sure), turned off the overrides, opened Spotify normally and everything was back to normal.
Not sure if this can be fixed by spicetify or if it won't break again with new Spotify and spicetify versions, but it does work.

@crimist
Copy link

crimist commented Sep 17, 2024

I think you nailed it. I checked in my ~/.config/spicetify/Extracted and found that Vietnamese was indeed SP while all the other fonts were Sp.

This seems to have somehow fixed itself on my system with the latest spicetify / spotify combo though. In fact there's no longer any Vietnamese files in ~/.config/spicetify/Extracted/Raw/xpui/fonts.

Spicetify 2.38.3

@ArtyIF
Copy link

ArtyIF commented Sep 23, 2024

Confirmed, latest version of Spotify + Spicetify 2.38.3 fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Something isn't working 🐧 linux
Projects
None yet
Development

No branches or pull requests

6 participants