Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible vulnerability #3078

Closed
2 tasks done
Al1-X opened this issue Jun 21, 2024 · 1 comment
Closed
2 tasks done

possible vulnerability #3078

Al1-X opened this issue Jun 21, 2024 · 1 comment
Labels
πŸ› bug Something isn't working

Comments

@Al1-X
Copy link

Al1-X commented Jun 21, 2024

πŸ” Have you checked Spicetify.app page for your issue?

  • I have checked the FAQ

πŸ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

β„Ή Environment / Computer Info

Spotify for Windows (64 bit)
1.2.39.578.g0ea3f38b
Spicetify v2.36.13

πŸ“ Description

Hello! I would like to point out a possible vulnerability issue. It is located at cli/src/utils/utils.go:74. The function io.Copy() does not limit the number of bytes that are read. This may lead, in certain cases, to uncontrolled memory and disk usage. If you agree that this is a problem, I suggest using io.CopyN().
Thank you!

https://pkg.go.dev/io#CopyN

πŸ“Έ Screenshots

image

@Al1-X Al1-X added the πŸ› bug Something isn't working label Jun 21, 2024
@rxri
Copy link
Member

rxri commented Jun 21, 2024

And how’s that a vulnerability if whatever is copied is hard-coded or typed into the config. Lol. Not everything is vulnerable if you use it in the way that doesn’t make it such

@rxri rxri closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants