Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom app run on start, not just when its tab is clicked #11

Closed
theRealPadster opened this issue Sep 28, 2021 · 5 comments
Closed
Labels
🐛 bug Something isn't working

Comments

@theRealPadster
Copy link
Member

Last I checked, extensions aren't loaded in until you open the marketplace app. We want them to be loaded in on Spotify launch.

@theRealPadster theRealPadster added 🐛 bug Something isn't working 🐤 good first issue Good for newcomers labels Sep 28, 2021
@afonsojramos
Copy link
Member

I actually think this may be part of the error in lyrics-plus 🤔 spicetify/cli#1090

@CharlieS1103
Copy link
Member

@afonsojramos Nah it's an issue with this, I was super lazy lol.

@theRealPadster
Copy link
Member Author

It's because it activates extensions in loadPage(), which is when the app is clicked in the sidebar. Needs to be in some other place.

@theRealPadster
Copy link
Member Author

Just updating the issue status:

It looks like Custom Apps can't execute any code until their icon is clicked. I put a console.log('loaded') just at the top of the main index.js file and it doesn't log until you click on it in the sidebar. I think we need some sort of hook or something added to Spicetify so that custom apps are able to execute code on app start, like extensions can.

Possible solution suggested was to add a value in the CustomApp's manifest for a js file that gets run as an extension (since they can run code on app start).

@theRealPadster theRealPadster removed the 🐤 good first issue Good for newcomers label Oct 7, 2021
@theRealPadster
Copy link
Member Author

This is implemented now! 🎉

93d1e70
332483a
a43ce36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants