Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Updated field labels and instructions only visible to admin users #2

Closed
gethyn1 opened this issue Mar 29, 2016 · 4 comments
Closed
Labels

Comments

@gethyn1
Copy link

gethyn1 commented Mar 29, 2016

Thanks for the great plugin.

It seems updated field labels and instructions are only visible for admin users. Any users who are not admin see the original field title and instructions.

Is this an intentional feature of the plugin?

@gethyn1
Copy link
Author

gethyn1 commented Mar 29, 2016

I've got this working for all users by editing line 71 in RelabelPlugin.php:

if(craft()->request->isCpRequest() && !craft()->request->isAjaxRequest() && craft()->userSession->isAdmin())

to:

if(craft()->request->isCpRequest() && !craft()->request->isAjaxRequest())

Will this have repercussions anywhere else?

@benjamminf
Copy link
Contributor

Hey @gethyn1 glad you like the plugin!

You've actually discovered a pretty big oversight, can't believe it hadn't been picked up for this long. If you want to open a pull request with this fix I'd be happy to merge it, otherwise I'll do it. Thanks for reporting this issue!

@gethyn1
Copy link
Author

gethyn1 commented Mar 31, 2016

Sorry - was out of the office yesterday. Good fix.

@benjamminf
Copy link
Contributor

No worries, just wanted to get this fixed and rolled out quick. Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants