Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaping of markdown special characters #4

Closed
spier opened this issue Dec 16, 2018 · 1 comment
Closed

Escaping of markdown special characters #4

spier opened this issue Dec 16, 2018 · 1 comment

Comments

@spier
Copy link
Owner

spier commented Dec 16, 2018

Some markdown special characters get escaped in the step convert_to_reference_style_links(content).

For example:
Goodbye\!

Currently we are performing a manual cleanup of those but that is quite error-prone.

I filed an issue with commonmarker to see if this behavior is actually correct:
gjtorikian/commonmarker#91
@spier
Copy link
Owner Author

spier commented Dec 22, 2018

I ended up using plain regex to implement the convert_to_reference_style_links functionality i..e I am not using commonmarker anymore.

@spier spier closed this as completed Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spier