Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming health check env variables #196

Merged
merged 3 commits into from
May 8, 2023

Conversation

mamy-CS
Copy link
Collaborator

@mamy-CS mamy-CS commented May 4, 2023

Addresses #195 and upgrades reactscripts to v5

Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS mamy-CS added this to the 1.2.x milestone May 4, 2023
@mamy-CS mamy-CS self-assigned this May 4, 2023
@mamy-CS mamy-CS changed the base branch from main to v1.2.0 May 4, 2023 20:47
@mamy-CS mamy-CS added enhancement New feature or request frontend Tornjak UI (Frontend) In Review labels May 4, 2023
Copy link
Collaborator

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates. Looks good!
We just have to fix the test errors, otherwise we good to go

Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mrsabath mrsabath merged commit 56bec29 into spiffe:v1.2.0 May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Tornjak UI (Frontend) In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants