Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI Logic to Build on PR #385

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Change CI Logic to Build on PR #385

merged 1 commit into from
Mar 28, 2024

Conversation

maia-iyer
Copy link
Collaborator

@maia-iyer maia-iyer commented Mar 28, 2024

The current CI logic only executes a build on push. Dependabot fails when the action is triggered by a push event instead of a pull request event: source

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer added github_actions Pull requests that update GitHub Actions code CI Enhancement labels Mar 28, 2024
@maia-iyer maia-iyer added this to the 1.6.x milestone Mar 28, 2024
@maia-iyer maia-iyer self-assigned this Mar 28, 2024
@maia-iyer maia-iyer marked this pull request as ready for review March 28, 2024 17:18
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maia-iyer maia-iyer merged commit 1e4c666 into v1.6 Mar 28, 2024
8 checks passed
@maia-iyer maia-iyer deleted the fix_ci_logic branch March 28, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Enhancement github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants