Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic auth client_id and keycloak_realm Env Variables #401

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Dynamic auth client_id and keycloak_realm Env Variables #401

merged 3 commits into from
Apr 15, 2024

Conversation

mamy-CS
Copy link
Collaborator

@mamy-CS mamy-CS commented Apr 11, 2024

Adding:

  • client_id
  • keycloak_realm
    as env variables in frontend

@mamy-CS
dynamic auth client id and keycloak realm
74f5879 
Signed-off-by: MohammedAbdi <mohammma@usc.edu>
@mamy-CS mamy-CS added this to the 1.6.x milestone Apr 11, 2024
@mamy-CS mamy-CS self-assigned this Apr 11, 2024
@mamy-CS mamy-CS linked an issue Apr 11, 2024 that may be closed by this pull request
Tornjak Frontend - dynamic auth client id automation #364
Closed
@mamy-CS mamy-CS added enhancement New feature or request frontend Tornjak UI (Frontend) labels Apr 11, 2024
maia-iyer
maia-iyer reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to add the documentation in this PR as well? I believe the docs/user-management.md and the ./USAGE.md files are the ones that need updates to the environment variable docs

@mamy-CS
add env auth variables in prod
e829e38 
Signed-off-by: MohammedAbdi <mohammma@usc.edu>
@mamy-CS
add documentation
3dabce7 
Signed-off-by: MohammedAbdi <mohammma@usc.edu>
maia-iyer
maia-iyer approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mamy-CS mamy-CS merged commit 0df3096 into v1.6 Apr 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maia-iyer maia-iyer maia-iyer approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb lumjjb is a code owner

@mrsabath mrsabath Awaiting requested review from mrsabath mrsabath is a code owner

Assignees

@mamy-CS mamy-CS

Labels
enhancement New feature or request frontend Tornjak UI (Frontend)
Projects
None yet
Milestone
1.6.x
Development

Successfully merging this pull request may close these issues.

Tornjak Frontend - dynamic auth client id automation
2 participants
@mamy-CS @maia-iyer