-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SPIRE scratch images in favor of alpine images #97
Conversation
SPIRE is planning to stop pushing the alpine-based release images to GCR. SPIRE has published scratch images that contain only the SPIRE release binary since v1.1.0 to GHCR as ghcr.io/spiffe/<image>. Update references to alpine images in GCR to scratch images in GHCR. Update places where a version < 1.1.0 is used to reference the latest version of SPIRE, as the scratch images are only published to GHCR as of v1.1.0. Signed-off-by: Ryan Turner <turner@uber.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks for opening this up @rturner3 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rturner3 This is great! We'll take it from here! 👍
Thanks @mrsabath! I noticed in the failing CI job that the Dockerfiles are trying to install
If the fix is straightforward, I'm happy to contribute it in this PR since it doesn't look like this is safe to merge as is. |
Thank you @rturner3 for reaching out. We fixed it by separating the Tornjak images from Spire (see #100) This is the most elegant way. We can still keep them both in a single pod, but as separate containers (e.g. a sidecar). This new Tornjak image is based on alpine, to address the lacking |
We are retiring the deployment model when Tornjak is together with SPIRE in the same container, in lieu of separate containers that can be deployed in the same pod. Tornjak requires |
SPIRE is planning to stop pushing the alpine-based release images to GCR. SPIRE has published scratch images that contain only the SPIRE release binary since v1.1.0 to GHCR as ghcr.io/spiffe/<image>.
Update references to alpine images in GCR to scratch images in GHCR. Update places where a version < 1.1.0 is used to reference the latest version of SPIRE, as the scratch images are only published to GHCR as of v1.1.0.