Components like tablist items, header/footer have no correct data

[andreasdc]

Bungeecord version

This server is running BungeeCord version git:BungeeCord-Bootstrap:1.20-R0.3-SNAPSHOT:ffa011c:1804 by md_5

Server version

No response

Client version

No response

Bungeecord plugins

The bug

After the lastest updates components like tablist items, header, footer don't have their data like: bold, italic, striketrough. I suppose this commit is the fault 737d545.

Log output (links)

No response

Checking

• I am using BungeeCord and not a fork. Issues with forks should not be reported here.
• I think this is not an issue with a bungeecord plugin.
• I have not read these checkboxes and therefore I just ticked them all.
• This is not a question or plugin creation help request.

[bob7l]

Unless I'm misunderstanding, I can't reproduce this issue on 1.8.9 or 1.20.4 using build 1804.

https://i.gyazo.com/4bf677b5469aae03f8debf4064f9bd8b.png

[andreasdc]

I was testing on 1.20.2 client, but I dont think thats the case. I was testing with older bungee and I didnt have it, I will test it again later.

[Janmm14]

Are these things are sent by bungee plugins or sent by the spigot server in both your setups?

[andreasdc]

They are sent by BungeeTabListPlus by bungee.

[Janmm14]

They are sent by BungeeTabListPlus by bungee.

Maybe @bob7l is using different bungee plugin or using a spigot plugin?

Either way it'd be best if you could do check whether that commit is actually the problem.

Could you provide one example source string which is incorrectly un-bolded? Or is just a simple §lAbcd also getting un-bolded?

[andreasdc]

They are sent by BungeeTabListPlus by bungee.

Maybe @bob7l is using different bungee plugin or using a spigot plugin?

Either way it'd be best if you could do check whether that commit is actually the problem.

Could you provide one example source string which is incorrectly un-bolded? Or is just a simple §lAbcd also getting un-bolded?

All strings are unbolded and don't have strikethrough. Let me try again.

[andreasdc]

This commit broke it...
231024b

[md-5]

Pretty sure that commit fixed an issue basically the same as what this ticket describes

[andreasdc]

This build works https://ci.md-5.net/job/BungeeCord/1776/
and this doesn't work https://ci.md-5.net/job/BungeeCord/1777/
Earlier I didn't have any issues with objects components, maybe it's a small mistake or something.
When I was debugging I think forcing that boolean made everything bold, so I think the issue is there.

[bob7l]

Anyone else able to reproduce this?

I just tried BungeeTabListPlus on Bungee alone, and even BungeeTabListPlus on Spigot alone and still can't reproduce it. Used a combination of hex colors, strikethrough, bold, etc. Works fine.

@andreasdc Maybe you should add some debug code in Bungee to outprint the JSON string before it's deserialized so we can see exactly what's being read

[andreasdc]

I think it gets to check '"true"', then it doesn't see it as boolean. Other objects are just 'true' and they are boolean.

[md-5]

I guess .getAsBoolean() used to parse string to Boolean.

I think whatever is writing a boolean as a string is wrong, but bungee could be more relaxed I guess

[Janmm14]

@andreasdc I think your BungeeTablistPlus version is from before jan 20 2024, because thats where they fixed this: CodeCrafter47/TabOverlayCommon@af98309

[andreasdc]

Yup, I have the old version, didn't see that update. Thanks for your finding!