SpinApp CRD Active Replicas Status Column is unclear

[bacongobbler]

Given the following manifest:

apiVersion: core.spinoperator.dev/v1
kind: SpinApp
metadata:
  name: hello-rust
spec:
  image: "bacongobbler/hello-rust:latest"
  replicas: 2
  executor: containerd-shim-spin

When I apply it to the cluster and run kubectl get spinapps, no replicas are shown.

><> k get spinapps
NAME         READY REPLICAS   EXECUTOR
hello-rust   2                containerd-shim-spin

However, the number of replicas are shown if I run k get spinapps hello-rust -o yaml:

><> k get spinapps hello-rust -o yaml
apiVersion: core.spinoperator.dev/v1
kind: SpinApp
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"core.spinoperator.dev/v1","kind":"SpinApp","metadata":{"annotations":{},"name":"hello-rust","namespace":"default"},"spec":{"executor":"containerd-shim-spin","image":"bacongobbler/hello-rust:latest","replicas":2}}
  creationTimestamp: "2024-02-20T19:07:23Z"
  generation: 1
  name: hello-rust
  namespace: default
  resourceVersion: "1663"
  uid: 41e1456e-6284-43ff-b37b-cbc302730b15
spec:
  checks: {}
  enableAutoscaling: false
  executor: containerd-shim-spin
  image: bacongobbler/hello-rust:latest
  replicas: 2
  resources: {}
  runtimeConfig: {}
status:
  activeScheduler: containerd-shim-spin
  conditions:
  - lastTransitionTime: "2024-02-20T19:07:25Z"
    message: Deployment has minimum availability.
    reason: MinimumReplicasAvailable
    status: "True"
    type: Available
  - lastTransitionTime: "2024-02-20T19:07:23Z"
    message: ReplicaSet "hello-rust-77496795b6" has successfully progressed.
    reason: NewReplicaSetAvailable
    status: "True"
    type: Progressing
  readyReplicas: 2

Possibly related to #86

[endocrimes]

READY REPLICAS is a single field (just bad whitespace) - and correctly shows 2

[bacongobbler]

Ah! That makes more sense now. Thank you.

Is there a way to change the output to match the output of kubectl get deployments?

><> k get deployments
NAME         READY   UP-TO-DATE   AVAILABLE   AGE
hello-rust   2/2     2            2           92m

In this case, I'm proposing we change the output of kubectl get spinapps to this:

NAME         READY  EXECUTOR
hello-rust   2/2    containerd-shim-spin

Or perhaps by hyphenating the output:

NAME         READY-REPLICAS   EXECUTOR
hello-rust   2                containerd-shim-spin

To me, it reads as two different tabs in the table output: one showing the number of "ready" replicas (0), and one showing the number of "expected" replicas (unknown).

[endocrimes]

Yep - you can update api/spinapp_types.go and change the comment annotation (then make manifests install will update all the kube-bits)

[bacongobbler]

Looks like you can't combine spec.replicas and status.readyReplicas into one "Ready" column like what kubectl get deployments does. There's a ticket upstream that is now inactive.

kubernetes/kubernetes#67268